ci(experiment): don't check in generated TS files by johanpel · Pull Request #255 · rapidsai/quent

johanpel · 2026-06-25T09:38:09Z

Description

Stop checking generated TypeScript bindings into the repository.

Bindings are generated into ui/generated/ts-bindings through the dedicated quent-simulator-ui-bindings package. This keeps each workflow self-contained:

pnpm build, pnpm typecheck, and development scripts generate bindings automatically.
Cargo builds with the ui feature generate bindings before building and embedding the UI.
CI can generate bindings independently for fast comparison and only reports a binding diff when one exists.
Cargo builds without the ui feature perform no binding or frontend work.

UI CI jobs now generate their own inputs instead of sharing a generated-bindings artifact.

Clean-state standalone Cargo and pnpm builds were verified with no generated bindings present. Consecutive embedded Cargo builds were also verified to avoid recompilation.

Written by Codex.

Example

The best way I could come up with surfacing whether TS bindings were changed was to make this check not skip (it will show skipped if there were no changes):

And then if you go to the UI summary tab, you can inspect them:

Any review comments based on those changes will still have to go to the Rust source of these bindings of course (unless we bump packages and the generators change).

johallar · 2026-06-30T15:40:54Z

for posterity: I need to make sure that the @quent packages are able to re-export the generated types correctly when built, and also add some "pre-dev" scripts to make sure types are generated so IDEs have types and typecheck works seamlessly locally.

# Description Enables the ts-rs formatting feature for simulator server bindings. Regenerates the bindings without trailing whitespace that can accidentally be removed when committing and ensures repeated builds produce stable output. Written by Codex. # Related issues #255 Authors: - Johan Peltenburg (https://github.com/johanpel) Approvers: - Matthijs Brobbel (https://github.com/mbrobbel) URL: #421

Remove the 52 generated TypeScript definitions from examples/simulator/server/ts-bindings/ from git tracking. They are regenerated on each CI run by building quent-simulator-server and uploaded as an artifact. Two new jobs in ui.yml: - generate-bindings: builds quent-simulator-server and uploads the generated ts-bindings/ as a CI artifact; all UI jobs that need the bindings download it before running. - diff-bindings: on pull requests, diffs the PR bindings against the base branch and posts the result to the step summary. The full bindings are also shown after the diff. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Removes bare `corepack enable pnpm` + `pnpm` calls that pulled in pnpm@11.9.0 via corepack, conflicting with the pinned pnpm@11.6.0. Also fixes the prettier config and write paths for `pnpm --dir ui exec` (which sets CWD to ui/). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@johallar

#393 merged generated ts bindings that weren't formatted using the changes of #421, this fixes them. cc. @johallar @cmatzenbach could we please consider #255 to avoid these issues altogether? Authors: - Johan Peltenburg (https://github.com/johanpel) Approvers: - Matthijs Brobbel (https://github.com/mbrobbel) - Dhruv Vats (https://github.com/dhruv9vats) URL: #424

…ed-checkin Signed-off-by: Johan Peltenburg <johan.peltenburg+code@gmail.com> # Conflicts: # examples/simulator/server/ts-bindings/CategoricalDecl.ts # examples/simulator/server/ts-bindings/CategoricalSeries.ts # examples/simulator/server/ts-bindings/CategoricalTimelineRequest.ts # examples/simulator/server/ts-bindings/DataFlowTimelineBinned.ts # examples/simulator/server/ts-bindings/DimensionKeyDecl.ts # examples/simulator/server/ts-bindings/MeasureDecl.ts

Signed-off-by: Johan Peltenburg <johan.peltenburg+code@gmail.com>

johanpel · 2026-07-22T05:55:54Z

Added some commits to make the bindings compile automatically as a part of pnpm run dev.

First bindings take some time to compile, but without Rust changes it's fast now:

# First run
Compiling quent-simulator-server ...
Finished `dev` profile ... in 17.84s
VITE v7.3.6 ready in 5197 ms

# Subsequent run (without Rust changes)
Finished `dev` profile ... in 1.05s
VITE v7.3.6 ready in 2173 ms

# After modifying an exported Rust type
Compiling quent-simulator-ui ...
Compiling quent-simulator-analyzer ...
Compiling quent-simulator-server ...
Finished `dev` profile ... in 5.91s
VITE v7.3.6 ready in 631 ms

Signed-off-by: Johan Peltenburg <johan.peltenburg+code@gmail.com>

coderabbitai · 2026-07-23T13:19:50Z

📝 Walkthrough

Walkthrough

The PR introduces a reusable Rust TypeScript-binding generator, moves UI consumers to shared generated bindings, adds binding-aware build scripts and Cargo integration, and extends CI to generate, compare, scan, and report binding changes.

Changes

TypeScript binding generation pipeline

Layer / File(s)	Summary
Reusable binding generator and Cargo wiring `Cargo.toml`, `examples/simulator/ui-bindings/*`, `domains/query_engine/server/Cargo.toml`, `examples/simulator/server/Cargo.toml`	Adds the workspace binding crate and parameterized generator, wires it into the query engine build dependencies, and removes the simulator server’s former binding dependencies.
UI binding paths and build scripts `ui/package.json`, `ui/packages/@quent//package.json`, `ui/packages/@quent/utils/src/types/index.ts`, `ui/config*`	Adds binding preparation and CI build scripts, and changes TypeScript resolution from simulator-server bindings to `ui/generated/ts-bindings`.
Cargo UI build orchestration `domains/query_engine/server/build.rs`	Gates UI builds on the feature, expands rebuild inputs, generates bindings, installs dependencies, and runs `pnpm ci:build`.
CI binding validation and repository support `.github/workflows/ui.yml`, `.github/workflows/license-check.yml`, `.coderabbit.yaml`, `.gitignore`	Expands workflow triggers, generates and compares bindings in pull requests, displays diffs, scans the updated paths for licenses, and ignores legacy/generated binding directories.
Development documentation `README.md`, `ui/README.md`	Documents Pixi setup, binding generation commands, Rust type changes, and Cargo-managed UI bundling.

Estimated code review effort: 3 (Moderate) | ~30 minutes

Possibly related PRs

rapidsai/quent#348: Also changes .coderabbit.yaml path filtering for simulator TypeScript bindings.
rapidsai/quent#422: Also modifies the SPDX license-check workflow.

Suggested reviewers: mbrobbel, cmatzenbach, dhruv9vats

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: stopping generated TS files from being checked in.
Description check	✅ Passed	The description covers the change, testing, and screenshots, but it omits the template's Related Issues section.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/license-check.yml:
- Line 26: Update the license-check workflow to generate the simulator
TypeScript bindings before collecting files, then reuse one shared file list
containing both tracked sources and generated bindings for license validation
and the reported count. Replace the index-only git ls-files input in the
relevant steps while preserving the existing extensions and output behavior.

In `@examples/simulator/server/build.rs`:
- Around line 20-55: Add tests for the sync_bindings function covering copying
generated files, avoiding writes when destination content is unchanged, and
removing stale .ts files while preserving current outputs. Use temporary
directories and assert both file contents and stale-file deletion behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: e8adb2a8-ca9d-4031-92e8-3bde0f445a95

📥 Commits

Reviewing files that changed from the base of the PR and between 88ff7cf and 1648571.

⛔ Files ignored due to path filters (68)

examples/simulator/server/ts-bindings/BinnedSpanSec.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/BulkTimelineRequest.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/BulkTimelinesResponse.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/BulkTimelinesResponseEntry.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/CapacityDecl.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/CapacityKind.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/CategoricalDecl.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/CategoricalSeries.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/CategoricalTimelineRequest.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/DataFlowTimelineBinned.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/DimensionKeyDecl.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/DynamicAttribute.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/DynamicList.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/DynamicStruct.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/DynamicValue.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/Edge.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/Engine.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/EngineImplementationAttributes.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/EntityFilter.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/EntityListEntry.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/EntityListFilter.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/EntityListRequest.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/EntityListResponse.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/EntityRef.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/EntityScope.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/EntitySortKey.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/FiniteStateMachine.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/FsmStateTypeDecl.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/FsmTransition.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/FsmTransitionDecl.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/FsmTypeDecl.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/FsmUsage.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/MeasureDecl.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/Operator.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/OperatorFilter.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/OperatorStatistics.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/PageParams.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/Plan.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/PlanTree.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/Port.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/PortStatistics.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/PrefixSystem.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/QuantitySpec.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/Query.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/QueryBundle.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/QueryEntities.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/QueryFilter.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/QueryGroup.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/Resource.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/ResourceGroup.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/ResourceGroupNode.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/ResourceGroupTimelineRequest.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/ResourceGroupTypeDecl.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/ResourceTimeline.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/ResourceTimelineBinned.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/ResourceTimelineBinnedByState.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/ResourceTimelineRequest.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/ResourceTree.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/ResourceTypeDecl.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/SingleTimelineRequest.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/SingleTimelineResponse.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/Sort.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/SortDir.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/SpanSec.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/TimeWindow.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/TimelineConfig.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/TimelineRequest.ts is excluded by !examples/simulator/server/ts-bindings/**
examples/simulator/server/ts-bindings/Worker.ts is excluded by !examples/simulator/server/ts-bindings/**

📒 Files selected for processing (13)

.github/workflows/license-check.yml
.github/workflows/rust.yml
.github/workflows/ui.yml
.gitignore
README.md
domains/query_engine/server/build.rs
examples/simulator/server/build.rs
ui/README.md
ui/package.json
ui/packages/@quent/client/package.json
ui/packages/@quent/components/package.json
ui/packages/@quent/hooks/package.json
ui/packages/@quent/utils/package.json

…ed-checkin

This reverts commit 5cb5c3e.

johanpel · 2026-07-23T17:28:39Z

The best way I could come up with surfacing whether TS bindings were changed was to make this check not skip (it will show skipped if there were no changes):

And then if you go to the UI summary tab, you can inspect them:

Any review comments based on those changes will still have to go to the Rust source of these bindings of course (unless we bump packages and the generators change).

johanpel · 2026-07-23T17:29:28Z

Tested this in commit 5cb5c3e

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

examples/simulator/ui-bindings/src/lib.rs (1)
22-41: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Add coverage for the binding generator.

Test generation into a temporary directory, including expected output creation and stale-file removal. This is the reusable contract that all UI build paths depend on.

As per coding guidelines, “New Rust components must include accompanying tests.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@examples/simulator/ui-bindings/src/lib.rs` around lines 22 - 41, Add tests
for the generate function that use a temporary directory, verify the expected
bindings are created, and confirm stale files are removed when generation runs.
Keep the test focused on the public generate contract and ensure temporary
resources are cleaned up automatically.
Source: Coding guidelines

🧹 Nitpick comments (1)

ui/packages/@quent/client/package.json (1)
12-15: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

Serialize binding generation for recursive package commands.

Each package independently runs the same root generator. Recursive pnpm commands execute across workspace projects with concurrency, causing redundant Cargo invocations and potentially concurrent writes to ui/generated/ts-bindings. Centralize generation for recursive flows or add serialization/idempotence.

ui/packages/@quent/client/package.json#L12-L15: adjust prebuild/pretypecheck.

ui/packages/@quent/components/package.json#L15-L18: adjust prebuild/pretypecheck.

ui/packages/@quent/hooks/package.json#L13-L16: adjust prebuild/pretypecheck.

ui/packages/@quent/utils/package.json#L12-L15: adjust prebuild/pretypecheck.

(pnpm.io)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ui/packages/`@quent/client/package.json around lines 12 - 15, Serialize
binding generation for recursive workspace commands by updating the prebuild and
pretypecheck scripts in ui/packages/@quent/client/package.json (12-15),
ui/packages/@quent/components/package.json (15-18),
ui/packages/@quent/hooks/package.json (13-16), and
ui/packages/@quent/utils/package.json (12-15). Centralize generation or
otherwise make these shared bindings commands serialized and idempotent, while
preserving the existing build and typecheck flows.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@examples/simulator/ui-bindings/src/lib.rs`:
- Around line 22-41: Add tests for the generate function that use a temporary
directory, verify the expected bindings are created, and confirm stale files are
removed when generation runs. Keep the test focused on the public generate
contract and ensure temporary resources are cleaned up automatically.

---

Nitpick comments:
In `@ui/packages/`@quent/client/package.json:
- Around line 12-15: Serialize binding generation for recursive workspace
commands by updating the prebuild and pretypecheck scripts in
ui/packages/@quent/client/package.json (12-15),
ui/packages/@quent/components/package.json (15-18),
ui/packages/@quent/hooks/package.json (13-16), and
ui/packages/@quent/utils/package.json (12-15). Centralize generation or
otherwise make these shared bindings commands serialized and idempotent, while
preserving the existing build and typecheck flows.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Enterprise

Run ID: 13d31af5-ae61-45b5-912f-1b83fe06066f

📥 Commits

Reviewing files that changed from the base of the PR and between 1648571 and 0903aa9.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock, !Cargo.lock

📒 Files selected for processing (22)

.coderabbit.yaml
.github/workflows/ui.yml
.gitignore
Cargo.toml
README.md
domains/query_engine/server/Cargo.toml
domains/query_engine/server/build.rs
examples/simulator/server/Cargo.toml
examples/simulator/ui-bindings/Cargo.toml
examples/simulator/ui-bindings/src/lib.rs
examples/simulator/ui-bindings/src/main.rs
ui/README.md
ui/eslint.config.js
ui/package.json
ui/packages/@quent/client/package.json
ui/packages/@quent/components/package.json
ui/packages/@quent/hooks/package.json
ui/packages/@quent/utils/package.json
ui/packages/@quent/utils/src/types/index.ts
ui/packages/@quent/utils/tsconfig.json
ui/tsconfig.json
ui/vite.config.ts

💤 Files with no reviewable changes (1)

examples/simulator/server/Cargo.toml

johallar

🙇 TYTY

johanpel · 2026-07-24T08:54:45Z

/merge

johanpel changed the title ~~experiment(ci): don't check in generated TS files~~ ci(experiment): don't check in generated TS files Jun 25, 2026

johanpel added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jun 25, 2026

johanpel self-assigned this Jun 25, 2026

johallar reviewed Jun 29, 2026

View reviewed changes

Comment thread ui/pnpm-workspace.yaml Outdated

johanpel force-pushed the quent-no-ts-generated-checkin branch from 80d5cfa to f0f3691 Compare June 29, 2026 15:27

johanpel mentioned this pull request Jul 20, 2026

fix(ts): format generated bindings #421

Merged

johanpel mentioned this pull request Jul 21, 2026

chore(ts): format bindings #424

Merged

johanpel and others added 2 commits July 21, 2026 08:40

johanpel added 3 commits July 21, 2026 14:41

fix(ui): finalize generated binding workflows

d09e281

Signed-off-by: Johan Peltenburg <johan.peltenburg+code@gmail.com>

fix(ui): make generated bindings reliable locally

d583f39

Signed-off-by: Johan Peltenburg <johan.peltenburg+code@gmail.com>

johanpel force-pushed the quent-no-ts-generated-checkin branch from 036f8df to d583f39 Compare July 21, 2026 13:28

ci: skip empty TypeScript binding reports

62368d4

Signed-off-by: Johan Peltenburg <johan.peltenburg+code@gmail.com>

johanpel mentioned this pull request Jul 22, 2026

chore: update coderabbit guidance + review guidelines markdown #434

Merged

fix(ci): avoid nested Cargo deadlock

1648571

Signed-off-by: Johan Peltenburg <johan.peltenburg+code@gmail.com>

johanpel marked this pull request as ready for review July 23, 2026 13:14

johanpel requested review from cmatzenbach, dhruv9vats and mbrobbel as code owners July 23, 2026 13:14

coderabbitai Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread .github/workflows/license-check.yml

Comment thread examples/simulator/ui-bindings/src/lib.rs Outdated

johanpel marked this pull request as draft July 23, 2026 13:47

johanpel added 2 commits July 23, 2026 16:30

refactor(ui): isolate TypeScript binding generation

e028262

fix(ui): exclude generated bindings from lint

f1f35e5

johanpel added 7 commits July 23, 2026 17:02

refactor(ui): simplify binding generation

27ed38a

Merge remote-tracking branch 'upstream/main' into quent-no-ts-generat…

11e0657

…ed-checkin

fix(ui): clean up binding generation

439fd83

docs: require Pixi development environment

0644bec

chore: trigger CI

cb96529

test commit

5cb5c3e

Revert "test commit"

0903aa9

This reverts commit 5cb5c3e.

johanpel marked this pull request as ready for review July 23, 2026 17:29

coderabbitai Bot reviewed Jul 23, 2026

View reviewed changes

johallar approved these changes Jul 23, 2026

View reviewed changes

mbrobbel approved these changes Jul 24, 2026

View reviewed changes

rapids-bot Bot merged commit 83e00c6 into rapidsai:main Jul 24, 2026
21 checks passed

Navigation Menu

Uh oh!

ci(experiment): don't check in generated TS files - #255

ci(experiment): don't check in generated TS files#255
rapids-bot[bot] merged 16 commits into
rapidsai:mainfrom
johanpel:quent-no-ts-generated-checkin

johanpel commented Jun 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

johallar commented Jun 30, 2026

Uh oh!

johanpel commented Jul 22, 2026

Uh oh!

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

johanpel commented Jul 23, 2026

Uh oh!

johanpel commented Jul 23, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

johallar left a comment

Uh oh!

johanpel commented Jul 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

johanpel commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Example

Uh oh!

Uh oh!

johallar commented Jun 30, 2026

Uh oh!

johanpel commented Jul 22, 2026

Uh oh!

coderabbitai Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

johanpel commented Jul 23, 2026

Uh oh!

johanpel commented Jul 23, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

johallar left a comment

Choose a reason for hiding this comment

Uh oh!

johanpel commented Jul 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

johanpel commented Jun 25, 2026 •

edited

Loading

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading