Make sure specifying default value or nothing behaves the same in KMeans
#6331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying the default value of a constructor argument or not specifying it at all should behave the same.
betatim
added
improvement
dantegd
reviewed
Feb 18, 2025
| @@ -196,6 +196,18 @@ class KMeans(UniversalBase, | |||
| <http://scikit-learn.org/stable/modules/generated/sklearn.cluster.KMeans.html>`_. | |||
| """ | |||
|
|
|||
| _hyperparam_interop_translator = { | |||
| "init": { | |||
| # k-means++ would work, but setting it explicitly changes the configuration | |||
betatim
changed the title
KMeans
viclafargue
approved these changes
Feb 19, 2025
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying the default value of a constructor argument or not specifying it at all should behave the same when the accelerator is turned on.
This only fixes up
KMeans(init=...), there might be more cases where this is needed.Also adds a "not implemented" for the elkan algorithm.