Add synchronization to coo_to_csr - #5640
Merged
rapids-bot[bot] merged 1 commit intoAug 31, 2026
Merged
Conversation
…m (no parameter to pass one in), so we need to synchronize
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ChuckHastings
marked this pull request as ready for review
August 28, 2026 18:42
ChuckHastings
added
bug
bdice
approved these changes
Aug 31, 2026
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
Do you plan to add a parameter (stream/handle/etc.) so that this function can be properly stream-ordered?
Collaborator
Author
There's an update to MST in the works in raft (NVIDIA/raft#3118). Once that's complete we'll be doing some testing within cugraph. I was going to use that as an opportunity to update some of the MST code in cugraph. |
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This legacy code is only used in MST and in some legacy python code. Performance is not critical.
We could add a handle so that we can all use the same stream, but that has breaking API implications. Simplest is to just add a synchronization call before leaving the function.