Skip to content

Conversation

@rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Nov 26, 2025

  • Requires that edge BC tests use NX 3.5 for comparisons, otherwise those tests are XFAIL'd.
    • Changes to NX 3.6 caused some comparisons in tests to fail when NX 3.6 is used as the reference. We're essentially skipping for now but will look into those changes (likely here)
  • This also updates the requires_nx marker to take up to 2 args for min and max required version, and a flag for skip vs. xfail.

@rlratzel rlratzel requested a review from a team as a code owner November 26, 2025 03:54
@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 26, 2025
@alexbarghi-nv
Copy link
Member

@rlratzel will this unblock #5354?

@ChuckHastings
Copy link
Collaborator

This is consistently failing a notebook test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants