Filter row groups using byte range in the new experimental parquet reader #20733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhaseeb123
commented
Nov 25, 2025
| void parquet_reader_options::set_skip_bytes(size_t val) | ||
| { | ||
| CUDF_EXPECTS(val == 0 or std::cmp_equal(_source.num_sources(), 1), | ||
| CUDF_EXPECTS(val == 0 or std::cmp_less_equal(_source.num_sources(), 1), |
Member
Author
There was a problem hiding this comment.
There is no internal source in case of the hybrid scan reader so relaxing the condition
mhaseeb123
added
feature request
mhaseeb123
commented
Nov 25, 2025
| * @param options Parquet reader options | ||
| * @return Filtered row group indices | ||
| */ | ||
| [[nodiscard]] std::vector<size_type> filter_row_groups_with_byte_range( |
mhaseeb123
commented
Nov 25, 2025
| auto const input_row_group_indices = | ||
| std::vector<std::vector<size_type>>{{row_group_indices.begin(), row_group_indices.end()}}; | ||
|
|
||
| return _impl->filter_row_groups_with_byte_range(input_row_group_indices, options).front(); |
davidwendt
reviewed
Nov 25, 2025
davidwendt
reviewed
Nov 25, 2025
davidwendt
reviewed
Nov 25, 2025
davidwendt
reviewed
Nov 25, 2025
Co-authored-by: David Wendt <[email protected]>
Co-authored-by: David Wendt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements filtering row groups using byte ranges in the new experimental parquet reader using the existing filtering APIs from the main parquet reader
Checklist