-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Add Windows x64 acceptance testing support..... maybe? #20543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
module: { | ||
# Not supported by Windows Meterpreter | ||
# MeterpreterTryToFork: false, | ||
MeterpreterDebugBuild: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should extend the testing of both Debug and Relese binaries for all architecture we support.
@diego, agreed, but I want to verify with people that made this. I don't know what the thought process is. |
I tracked down the PR in which this was initially added in to #18210. It doesn't mention any reason for omitting x64. It may not have been considered necessary at the time. I think in order to get these tests running so they can be confirmed before we merge this, we need to go through the Payload Testing steps to update the references to point to this branch. With that and the label in place, the new changes should run so we can get this approved and merged. We'll just want to revert the changes back after the new tests have run. |
The tests appear to run in the checks for this PR under the |
x64/meterpreter_reverse_tcp x64/meterpreter/reverse_https x64/meterpreter_reverse_http x64/meterpreter/bind_tcp meterpreter_bind_tcp
Some observations. For currently unknown reasons, http[s] payloads do not work. For known reasons, bind payloads do not work:
Note we assign lhost, even though this is a bind payload.
As such, I just added the x64 meterpreter back and will leave just those 2 payloads for now. I'll likely close this PR and put up a new one, as there's no reason to cloud up the commit history on upstream, but having a history of this for breadcrumbs might be useful. |
I'm hoping this adds tests for x64 Windows Meterpreters?
