-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Adding global sort order options #125
Conversation
Pull Request Test Coverage Report for Build 8311285451Details
💛 - Coveralls |
Tank you very much. The code looks good to me. If not already done, please apply prettier. |
I reverted my prettier run as it updated a bunch of unrelated changes but I'll give it a go and let you take a look, also adding docs at the bottom of the readme |
7fdb775
to
ebc1dda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the href in Postgrest supports specifying the position of nulls in sort [Ordering](https://postgrest.org/en/v12/references/api/tables_views.html#ordering). This can be configured via an optional data provider parameter:
and let it link [sort ordering]. Thanks.
ebc1dda
to
96f8d4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the effort, looks good to me!
Adding sort orders options. They are a bit verbose but do explain themselves rather well. I can update docs but given it's an optional param I didn't want to confuse new users in the initial example. Also added a test that covers all cases. In the event a user selects an order that matches postgres natural sorting we don't append the null ordering param to keep behavior consistant with existing functionality.
Fixes #124