Fix update fails when nothing is changed (#166)

Closes #141
raphiniert-com · Sep 4, 2024 · 7c896f5 · 7c896f5
1 parent b282e86
commit 7c896f5
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/src/index.ts b/src/index.ts
@@ -305,6 +305,9 @@ export default (config: IDataProviderConfig): DataProvider => ({
         const query = getQuery(primaryKey, id, resource, meta);
         const url = `${config.apiUrl}/${resource}?${qs.stringify(query)}`;
         const changedData = getChanges(data, previousData);
+        if (Object.keys(changedData).length === 0) {
+            return Promise.resolve({ data: { ...previousData } });
+        }
         const metaSchema = params.meta?.schema;
 
         const body = JSON.stringify({

diff --git a/src/urlBuilder.ts b/src/urlBuilder.ts
@@ -178,7 +178,7 @@ export const getPrimaryKey = (
     resource: string,
     primaryKeys: Map<string, PrimaryKey>
 ) => {
-    return primaryKeys.get(resource) || ['id'];
+    return (primaryKeys && primaryKeys.get(resource)) || ['id'];
 };
 
 export const decodeId = (

diff --git a/tests/dataProvider/update.test.ts b/tests/dataProvider/update.test.ts
@@ -1,5 +1,6 @@
 import qs from 'qs';
 import { makeTestFromCase, Case } from './helper';
+import dataProviderBuilder from '../../src';
 
 describe('update specific', () => {
     const method = 'update';
@@ -31,4 +32,14 @@ describe('update specific', () => {
     ];
 
     cases.forEach(makeTestFromCase);
+
+    it('should not fail when no changes are requested', async () => {
+        const dataProvider = dataProviderBuilder({} as any);
+        const { data } = await dataProvider.update('posts', {
+            id: 123,
+            data: { foo: 'bar' },
+            previousData: { id: 123, foo: 'bar' },
+        });
+        expect(data).toEqual({ id: 123, foo: 'bar' });
+    });
 });