Skip to content

feat(library): require questions for displayed documents - #1870

Closed
simple-agent-manager[bot] wants to merge 1 commit into
mainfrom
sam/kv-chat-caching-stuff-7rppw3
Closed

feat(library): require questions for displayed documents#1870
simple-agent-manager[bot] wants to merge 1 commit into
mainfrom
sam/kv-chat-caching-stuff-7rppw3

Conversation

@simple-agent-manager

Copy link
Copy Markdown
Contributor

Summary

  • Require question on display_from_library and remove the caption/title-style display contract
  • Add validated lineGroups with a 3-line default context marker for document cards
  • Preserve/render question and line group metadata in project chat document cards

Verification

  • pnpm --filter @simple-agent-manager/shared build
  • pnpm --filter @simple-agent-manager/providers build
  • pnpm --filter @simple-agent-manager/cloud-init build
  • pnpm --filter @simple-agent-manager/ui build
  • pnpm --filter @simple-agent-manager/acp-client build
  • pnpm --filter @simple-agent-manager/terminal build
  • pnpm --filter @simple-agent-manager/api test -- mcp-library-tools compact-mode
  • pnpm --filter @simple-agent-manager/web test -- document-card
  • pnpm --filter @simple-agent-manager/api typecheck
  • pnpm --filter @simple-agent-manager/web typecheck

Notes

This branch implements the current library-document question/line-group contract. The separate SSE acknowledgement event discussed in chat should be added where the final question stream endpoint is implemented.

@codspeed-hq

codspeed-hq Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing sam/kv-chat-caching-stuff-7rppw3 (333f444) with main (6b76580)

Open in CodSpeed

@sonarqubecloud

Copy link
Copy Markdown

@simple-agent-manager

Copy link
Copy Markdown
Contributor Author

Closing this because I opened it from a branch/context misunderstanding. The intended architecture viewer work is being pushed to existing PR #1817 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant