feat(library): require questions for displayed documents - #1870
Closed
simple-agent-manager[bot] wants to merge 1 commit into
Closed
feat(library): require questions for displayed documents#1870simple-agent-manager[bot] wants to merge 1 commit into
simple-agent-manager[bot] wants to merge 1 commit into
Conversation
Contributor
|
Contributor
Author
|
Closing this because I opened it from a branch/context misunderstanding. The intended architecture viewer work is being pushed to existing PR #1817 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
questionondisplay_from_libraryand remove the caption/title-style display contractlineGroupswith a 3-line default context marker for document cardsVerification
pnpm --filter @simple-agent-manager/shared buildpnpm --filter @simple-agent-manager/providers buildpnpm --filter @simple-agent-manager/cloud-init buildpnpm --filter @simple-agent-manager/ui buildpnpm --filter @simple-agent-manager/acp-client buildpnpm --filter @simple-agent-manager/terminal buildpnpm --filter @simple-agent-manager/api test -- mcp-library-tools compact-modepnpm --filter @simple-agent-manager/web test -- document-cardpnpm --filter @simple-agent-manager/api typecheckpnpm --filter @simple-agent-manager/web typecheckNotes
This branch implements the current library-document question/line-group contract. The separate SSE acknowledgement event discussed in chat should be added where the final question stream endpoint is implemented.