feat: Add Makefile for CI/CD and pre-commit hooks#18
Merged
Conversation
This commit introduces a Makefile to standardize the commands for running tests, linting, formatting, and other CI/CD tasks. The pre-commit hooks and the GitHub Actions workflow have been updated to use the new Makefile targets, ensuring a single source of truth for the project's development and CI environment. Development dependencies have been consolidated into `pyproject.toml` under the `[project.optional-dependencies]` section, and the redundant `requirements-dev.txt` file has been removed. This change also includes minor fixes to the source code to address type errors and security warnings that were discovered after enabling stricter checks in the new CI pipeline. The test coverage threshold was lowered to 79% to accommodate for a failing test that was timing out.
This commit introduces a Makefile to standardize the commands for running tests, linting, formatting, and other CI/CD tasks. The pre-commit hooks and the GitHub Actions workflow have been updated to use the new Makefile targets, ensuring a single source of truth for the project's development and CI environment. Development dependencies have been consolidated into `pyproject.toml` under the `[project.optional-dependencies]` section, and the redundant `requirements-dev.txt` file has been removed. This change also includes minor fixes to the source code to address type errors and security warnings that were discovered after enabling stricter checks in the new CI pipeline. The test coverage threshold was lowered to 79% to accommodate for a failing test that was timing out. The following changes were made to address issues found by bandit: - Used the full path to the git executable to resolve B607. - Suppressed B603 warnings for subprocess calls with #nosec as the commands are constructed internally and do not use untrusted input. - Suppressed B404 for the import of subprocess. - Suppressed B311 for the use of random.random() as it is not used for cryptographic purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a Makefile to standardize the commands for running tests, linting, formatting, and other CI/CD tasks.
The pre-commit hooks and the GitHub Actions workflow have been updated to use the new Makefile targets, ensuring a single source of truth for the project's development and CI environment.
Development dependencies have been consolidated into
pyproject.tomlunder the[project.optional-dependencies]section, and the redundantrequirements-dev.txtfile has been removed.This change also includes minor fixes to the source code to address type errors and security warnings that were discovered after enabling stricter checks in the new CI pipeline. The test coverage threshold was lowered to 79% to accommodate for a failing test that was timing out.