Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seedimage build-disk command #606

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Feb 2, 2024

The --unprivileged flag was removed and --system was added.

rancher/elemental-toolkit#1906

The --unprivileged flag was removed and --system was added.

Signed-off-by: Fredrik Lönnegren <[email protected]>
@frelon frelon force-pushed the update-seedimage-build-disk-cmd branch from 55b0949 to 4d5baa0 Compare February 2, 2024 08:29
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e523a25) 53.79% compared to head (4d5baa0) 53.80%.

Files Patch % Lines
controllers/seedimage_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #606   +/-   ##
=======================================
  Coverage   53.79%   53.80%           
=======================================
  Files          40       40           
  Lines        6071     6070    -1     
=======================================
  Hits         3266     3266           
+ Misses       2519     2518    -1     
  Partials      286      286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frelon frelon marked this pull request as ready for review February 2, 2024 09:12
@frelon frelon requested a review from a team as a code owner February 2, 2024 09:12
Copy link
Contributor

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frelon frelon merged commit eac1747 into rancher:main Feb 2, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants