fix: add ARG GO_IMAGE to Dockerfile for updatecli pipeline - #1029
Draft
briandowns with Copilot wants to merge 2 commits into
Draft
fix: add ARG GO_IMAGE to Dockerfile for updatecli pipeline#1029briandowns with Copilot wants to merge 2 commits into
briandowns with Copilot wants to merge 2 commits into
Conversation
The updatecli pipeline "Update build base version" was failing because
it expected `ARG GO_IMAGE=rancher/hardened-build-base:...` in the
Dockerfile to read and update the build base version, but the Dockerfile
had the image hardcoded directly in the `FROM` instruction.
Add `ARG GO_IMAGE=rancher/hardened-build-base:v1.26.5b1` before the
first `FROM` and change the FROM to use `${GO_IMAGE}`. This matches
the pattern used in other rancher repos (e.g., ecm-distro-tools) and
is what the updatecli config was designed to work with.
Also update the example version comments in updatebuildbase.yaml to
reflect the current version.
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job updatecli
fix: add ARG GO_IMAGE to Dockerfile for updatecli pipeline
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
updatecliCI job was failing because theupdatebuildbase.yamlpipeline reads the current build base version viaARG GO_IMAGEin the Dockerfile, butpackage/Dockerfilehad the image hardcoded directly in theFROMinstruction — the ARG didn't exist, causing an empty transformer input error.Changes
package/Dockerfile: AddARG GO_IMAGE=rancher/hardened-build-base:v1.26.5b1before the first stage and reference it via${GO_IMAGE}, matching the pattern used across the rancher ecosystemupdatecli/updatecli.d/updatebuildbase.yaml: Update example version strings in comments to reflect the current version