Added an optional aws_session_token variable - #35
Conversation
igomez06
left a comment
igomez06
left a comment
There was a problem hiding this comment.
Just one comment about make the aws session token optional through the yaml.
|
|
||
| variable "aws_access_key" {} | ||
| variable "aws_secret_key" {} | ||
| variable "aws_session_token" { |
There was a problem hiding this comment.
Yash if it's optional I think we need to default it. The optional aspect should go here: https://github.com/rancherlabs/corral-packages/blob/main/templates/aws/nodes/manifest.yaml
There was a problem hiding this comment.
@igomez06 for reference https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp_use-resources.html
Since I was using a temporary token, I had to set this variable
There was a problem hiding this comment.
@l4zy0n3 But it's not really answering my question how are you setting this? And why isn't it in the manifest.yaml? Are you reading it as an env var? How would you set this in a Jenkins job?
|
Hi @igomez06 , If this looks ok, can we merge this? |
| variable "corral_name" {} // name of the corral being created | ||
| variable "corral_user_id" {} // how the user is identified (usually github username) | ||
| variable "corral_public_key" {} // The corrals public key. This should be installed on every node. | ||
| variable "corral_name" {} // name of the corral being created |
There was a problem hiding this comment.
Last point why does it have all of this formatting changes? Is this necessary?
There was a problem hiding this comment.
sure, @igomez06, I'll revert the unnecessary formatting
2 participants
aws_session_token is required for some aws accounts to access aws