Skip to content

feat(hermes): add pr2045 object-literal accessor home-object patch#50

Closed
ramonclaudio wants to merge 1 commit into
chore/drop-babel-preset-pr56816from
feat/hermes-pr2045
Closed

feat(hermes): add pr2045 object-literal accessor home-object patch#50
ramonclaudio wants to merge 1 commit into
chore/drop-babel-preset-pr56816from
feat/hermes-pr2045

Conversation

@ramonclaudio

Copy link
Copy Markdown
Owner

Add the hermes source patch for facebook/hermes#2045, a cherry-pick of 18a9634659 onto the 250829098.0.0-stable branch React Native 0.85 ships.

genObjectExpr passed nullptr as the home object when generating an object-literal getter or setter, so super.x inside an accessor compiled against a null home object and SIGSEGV'd hermesc at compile time. The cherry-pick makes accessors pass capturedObj, matching the regular-method path.

This is the source-level replacement for the super-in-object-accessor workaround dropped with @react-native/babel-preset #56816. Apply it with git apply against a facebook/hermes checkout on the V1 branch. Root cause facebook/hermes#1761.

  • add packages/hermes/hermes-pr2045.patch
  • add the hermes row to the Open table

@ramonclaudio ramonclaudio deleted the branch chore/drop-babel-preset-pr56816 June 4, 2026 20:11
@ramonclaudio ramonclaudio deleted the feat/hermes-pr2045 branch June 4, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant