Link bounty list action surfaces#920
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe bounties list template now renders a per-bounty "next-steps-actions" block with links to the details page, JSON details, and active attempts endpoints. Tests assert the action group's ARIA label and that the JSON and attempts links use the open bounty's ID. ChangesBounty action links UI and tests
Possibly related PRs
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 77e21059-04ae-416c-891f-e0f92036b32d
📒 Files selected for processing (2)
app/templates/bounties.htmltests/test_bounty_pages.py
|
Follow-up for the CodeRabbit test-strength note. Updated head: Change:
Validation rerun:
|
pqmfei
left a comment
There was a problem hiding this comment.
Reviewed PR #920 at current head 1e18cf7f36ed22d6f808fb31c44c0eccc03364d8 as a non-author.
Evidence checked:
- inspected
app/templates/bounties.htmlandtests/test_bounty_pages.py; - confirmed the bounty list cards now expose only existing internal navigation surfaces:
/bounties/{id},/api/v1/bounties/{id}, and/api/v1/bounties/{id}/attempts; - verified the new action group is scoped by bounty id through
aria-label="Bounty action links for {id}"and the regression asserts the exact label plus JSON and active-attempt links for the open bounty; - checked GitHub state before review: PR open,
mergeStateStatus=CLEAN, hostedQuality, readiness, docs, and image checkssuccessful, CodeRabbit successful/no actionable comments on the current head, and no current-head human review visible; - checked
scripts/review_bounty_candidates.py --repo ramimbo/mergework --reviewer pqmfei --format textreported PR #920 ascandidate_for_fresh_review.
Validation on this exact head:
.\.venv\Scripts\python.exe -m pytest tests\test_bounty_pages.py -q-> 18 passed, 1 existing Starlette/httpx warning..\.venv\Scripts\python.exe -m ruff check tests\test_bounty_pages.py-> passed..\.venv\Scripts\python.exe -m ruff format --check tests\test_bounty_pages.py-> 1 file already formatted..\.venv\Scripts\python.exe scripts\docs_smoke.py-> docs smoke ok.git diff --check origin/main...HEAD-> clean.git merge-tree --write-tree origin/main HEAD-> clean tree31df8d17f33d2b324c00463980c581559a05a907.
Scope: read-only review of public bounty-list card navigation links and focused tests. No bounty API shape, attempt creation, payout execution, treasury mutation, ledger mutation, wallet behavior, admin-token behavior, private data, credentials, exchange, bridge, cash-out, or MRWK price behavior was used or changed.
akmhatey-ai
left a comment
There was a problem hiding this comment.
Reviewed current head 1e18cf7f36ed22d6f808fb31c44c0eccc03364d8.
Verdict: approved from the public bounty-list routing and regression coverage angle.
What I checked:
- #845 is live, labeled
mrwk:bounty, and reserved on the public MRWK bounty row. - The diff is limited to
app/templates/bounties.htmlandtests/test_bounty_pages.py. - The new list-card actions point to existing public routes:
/bounties/{id},/api/v1/bounties/{id}, and/api/v1/bounties/{id}/attempts. - Existing source issue, status/search/sort, availability, capacity, lifecycle, and payout-related behavior is not changed by this patch.
- Same-surface duplicate check: #643 had no visible
pull/920,#920, orPR #920review-bounty claim before this review; #845's visible earlier claims cover different surfaces such as docs/API preflight, bounty-detail routing, submission requirements, source-filter clearing, summary counters, and detail lifecycle display.
Validation I ran locally on a clean PR worktree:
uv run --python 3.12 --extra dev python -m pytest tests/test_bounty_pages.py -q-> 18 passed, 1 existing Starlette/httpx warning.uv run --python 3.12 --extra dev ruff check tests/test_bounty_pages.py-> passed.uv run --python 3.12 --extra dev ruff format --check tests/test_bounty_pages.py-> 1 file already formatted.uv run --python 3.12 --extra dev python scripts/docs_smoke.py-> docs smoke ok.git diff --check origin/main...HEAD-> clean.git merge-tree --write-tree origin/main HEAD-> clean tree31df8d17f33d2b324c00463980c581559a05a907.gitleaks detect --source . --no-banner --redact --log-level warn-> no findings.
Limitation: I did not run a browser screenshot; this review is route/template/test based.
No private data, credentials, wallet material, production mutation, payout execution, treasury execution, ledger mutation, exchange, bridge, cash-out, price behavior, or fabricated payout claims were used.
Bounty #845
Summary
Why this fits #845
The bounty list already shows source issue and capacity context, while the detail page exposes JSON details and active attempt checks. This PR brings those same low-risk routing actions onto the list cards so contributors and agents can move directly from discovery to preflight/duplicate checking without opening each detail page first.
Duplicate / scope check
bounty list action links attempts JSON details,bounties page attempts link, andCheck active attemptsfound no open PR adding card-level list actions.Validation
uv run --python 3.12 --extra dev python -m pytest tests/test_bounty_pages.py -q-> 18 passed, 1 existing Starlette/httpx warning.uv run --python 3.12 --extra dev ruff check tests/test_bounty_pages.py-> passed.uv run --python 3.12 --extra dev ruff format --check tests/test_bounty_pages.py-> 1 file already formatted.uv run --python 3.12 --extra dev python scripts/docs_smoke.py-> docs smoke ok.git diff --check origin/main...HEAD-> clean.git merge-tree --write-tree origin/main HEAD-> clean treeabda6f4c7b8cc6d19c1ef4bc0fd2711b121cfce1.Summary by CodeRabbit
New Features
Tests