Document live bounty preflight checks#883
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds documentation and tests that require agents and contributors to verify a live public bounty row (by repo+issue_number) and check pending ChangesLive-vs-Pending Bounty Discovery
Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
MolhamHamwi
left a comment
There was a problem hiding this comment.
Current-head review for #838 on 447508d66b50b4d8c68e239cf9deb44a8a888a76.
Evidence checked:
- Inspected the doc-only changes in
docs/agent-guide.mdanddocs/api-examples.md; the new live-vs-pending preflight points agents at the exact bounty row lookup plus the pendingcreate_bountyproposal queue, and keeps the claimable boundary tied to an open public row, positiveeffective_awards_remaining, and theReserved on MergeWorkcomment. - Inspected
tests/test_docs_public_urls.py; the assertions cover the new preflight language and both API paths so later edits cannot silently remove the contributor-routing warning. - Verified GitHub reports head
447508d66b50b4d8c68e239cf9deb44a8a888a76, merge stateUNSTABLE, with the project quality check successful and only CodeRabbit informational. - Ran
./.venv/bin/python -m pytest tests/test_docs_public_urls.py -qlocally: 35 passed. - Ran
./.venv/bin/python -m ruff check docs/agent-guide.md docs/api-examples.md tests/test_docs_public_urls.py: passed.
No blocker found. The added guidance is narrowly scoped, public-safe, and helps prevent agents from claiming pending-only bounty proposals as live work.
There was a problem hiding this comment.
Actionable comments posted: 4
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: cbd65e27-4d0d-4e58-b8b7-7787cefa23e7
📒 Files selected for processing (3)
docs/agent-guide.mddocs/api-examples.mdtests/test_docs_public_urls.py
mauricemohr88-debug
left a comment
There was a problem hiding this comment.
Current-head review for #838 on 4b735e701a76ab00aa873f02e3089e521a765b59.
Evidence checked:
- Inspected the doc-only updates in
docs/agent-guide.mdanddocs/api-examples.md; the new live-vs-pending preflight points agents at the exact public bounty row lookup and pendingcreate_bountyproposal queue. - Verified the claimable boundary stays tied to an open public bounty row, positive
effective_awards_remaining, themrwk:bountylabel, and theReserved on MergeWorkclaims-open comment. - Inspected
tests/test_docs_public_urls.py; the assertions cover the new guidance and both public API paths so the preflight warning cannot silently disappear. - Confirmed the current GitHub head is
4b735e701a76ab00aa873f02e3089e521a765b59, the PR is open, merge state is clean, and both visible checks are successful. - Ran
uv run --python 3.12 --extra dev python -m pytest tests/test_docs_public_urls.py -q: 35 passed. - Ran
uv run --python 3.12 --extra dev ruff check docs/agent-guide.md docs/api-examples.md tests/test_docs_public_urls.py: passed. - Ran
uv run --python 3.12 --extra dev ruff format --check tests/test_docs_public_urls.py: 1 file already formatted. - Ran
uv run --python 3.12 --extra dev python scripts/docs_smoke.py: docs smoke ok. - Ran
git diff --check origin/main...HEADandgit merge-tree --write-tree origin/main HEAD: clean.
No blocker found. The current-head update is narrow, public-safe, and reduces the chance that contributors or agents claim pending-only bounty proposals as live work.
alan747271363-art
left a comment
There was a problem hiding this comment.
Reviewed current head 4b735e701a76ab00aa873f02e3089e521a765b59 against current origin/main d7e9b530fffec7bd774da7708597648096a37393.
Scope inspected:
docs/agent-guide.mddocs/api-examples.mdtests/test_docs_public_urls.py
The visible PR diff is still docs/test-only and remains useful: it documents the live-vs-pending bounty preflight using the public bounty row and pending create_bounty proposal queue, keeps claimability tied to the public row, positive effective capacity, mrwk:bounty, and Reserved on MergeWork, and adds docs assertions so the guidance is not silently removed later. It does not change runtime behavior, proposal execution, payout execution, ledger, wallet, admin, private data, secrets, or off-ramp behavior.
Validation on this exact head:
.\.venv\Scripts\python.exe -m pytest tests\test_docs_public_urls.py -q-> 35 passed..\.venv\Scripts\python.exe scripts\docs_smoke.py-> docs smoke ok..\.venv\Scripts\python.exe -m ruff check docs\agent-guide.md docs\api-examples.md tests\test_docs_public_urls.py-> passed..\.venv\Scripts\python.exe -m ruff format --check tests\test_docs_public_urls.py-> 1 file already formatted.git diff --check origin/main...HEAD-> clean.
Current blocker: GitHub now reports mergeStateStatus=DIRTY / conflicting. git merge-tree --write-tree origin/main HEAD exits non-zero with a current-main conflict in tests/test_activity.py. That file is not part of the visible PR diff, so this looks like a branch-base/rebase conflict rather than a documentation-content problem, but it still blocks merging and needs a rebase/resolve.
No private data, credentials, wallet material, production mutation, payout execution, treasury execution, ledger mutation, exchange, bridge, cash-out, price behavior, or fabricated payout claims were used.
Summary
create_bountyproposal queue checks before opening or claiming work.executes_afteris opening-soon work, not a live claim lane, until the public bounty row andReserved on MergeWorkcomment exist.Bounty #845
Evidence
This is intentionally distinct from useful open contributor-flow PRs:
/api/v1/bountiesand/api/v1/treasury/proposalsAPIs.Validation
uv run --extra dev python -m pytest tests/test_docs_public_urls.py -q->35 passeduv run --extra dev python scripts/docs_smoke.py->docs smoke okuv run --extra dev ruff check docs/agent-guide.md docs/api-examples.md tests/test_docs_public_urls.py-> passeduv run --extra dev ruff format --check tests/test_docs_public_urls.py->1 file already formattedgit diff --check origin/main...HEAD-> cleangit merge-tree --write-tree origin/main HEAD-> clean tree74c5f4ba4b5d171d164f3cfaa94eccf148075d97Scope
Docs and docs-smoke assertions only. No runtime behavior, tokens, secrets, private data, payout execution, or price/cash-out claims are changed.
Summary by CodeRabbit
Documentation
Tests