Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSEGOG-128 Image centroids/crosshairs #521

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

louise-davies
Copy link
Member

@louise-davies louise-davies commented Nov 28, 2024

Description

Adds the ability to go into "crosshairs" mode. When switching into this mode, it will display the centroid for the image and the corresponding intensity plots. The user can click on the image to reposition the crosshairs. Resetting the view resets back to the centroid.

It should work when switching via the thumbnail selector, we always default to the centroid though.

image

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • Play around with the crosshairs mode

Agile board tracking

Closes DSEGOG-128

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 97.08940% with 14 lines in your changes missing coverage. Please review.

Project coverage is 97.87%. Comparing base (fa72dc6) to head (4ec5c98).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
src/images/imageView.component.tsx 89.47% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #521      +/-   ##
===========================================
- Coverage    97.90%   97.87%   -0.04%     
===========================================
  Files           93       94       +1     
  Lines        12153    12586     +433     
  Branches      1919     1451     -468     
===========================================
+ Hits         11899    12318     +419     
- Misses         252      266      +14     
  Partials         2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louise-davies louise-davies marked this pull request as ready for review December 5, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant