Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow names to change capitalisation in patch requests #265 #271

Merged
merged 7 commits into from
Jun 7, 2024

Conversation

joshuadkitenge
Copy link
Collaborator

@joshuadkitenge joshuadkitenge commented May 15, 2024

Description

see #265

Testing instructions

  • Review code
  • Check Actions build

Agile board tracking

closes #265

Copy link
Collaborator

@joelvdavies joelvdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments worked well with ral-facilities/inventory-management-system#554.

test/e2e/test_catalogue_category.py Outdated Show resolved Hide resolved
test/e2e/test_system.py Outdated Show resolved Hide resolved
test/unit/repositories/test_catalogue_category.py Outdated Show resolved Hide resolved
test/unit/repositories/test_catalogue_category.py Outdated Show resolved Hide resolved
test/unit/repositories/test_manufacturer.py Outdated Show resolved Hide resolved
test/unit/repositories/test_system.py Outdated Show resolved Hide resolved
@joshuadkitenge joshuadkitenge requested a review from VKTB May 20, 2024 11:55
inventory_management_system_api/repositories/system.py Outdated Show resolved Hide resolved
test/e2e/test_system.py Outdated Show resolved Hide resolved
test/unit/repositories/test_manufacturer.py Outdated Show resolved Hide resolved
test/unit/repositories/test_manufacturer.py Outdated Show resolved Hide resolved
test/unit/repositories/test_system.py Outdated Show resolved Hide resolved
test/unit/repositories/test_system.py Outdated Show resolved Hide resolved
@joshuadkitenge joshuadkitenge marked this pull request as ready for review June 4, 2024 07:33
@joshuadkitenge joshuadkitenge merged commit f6cc41c into develop Jun 7, 2024
6 checks passed
@joshuadkitenge joshuadkitenge deleted the allow-names-to-change-capitalosation-#265 branch June 7, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow names to change capitalisation
3 participants