Add creation modified times #100 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelvdavies
force-pushed
the
add-creation-modified-times-#100
branch
from
3422aaf to
72fe4d2
Compare
VKTB
reviewed
Feb 20, 2024
VKTB
force-pushed
the
add-creation-modified-times-#100
branch
from
b001b13 to
781a442
Compare
joelvdavies
commented
Feb 21, 2024
VKTB
previously approved these changes
Feb 22, 2024
I have also reviewed yours and they look good to me too (I can't approve as its my PR) |
VKTB
approved these changes
Feb 22, 2024
MatteoGuarnaccia5
approved these changes
Feb 22, 2024
| **FULL_CATALOGUE_ITEM_A_INFO, | ||
| **{ | ||
| **FULL_CATALOGUE_ITEM_A_INFO, | ||
| "created_time": FULL_CATALOGUE_ITEM_A_INFO["created_time"] - timedelta(days=5), |
There was a problem hiding this comment.
why is there this - timedelta(days=5) in a lot of the tests? I don't understand what its purpose is
There was a problem hiding this comment.
Both create and update times are generated when something is created and only the update time gets updated when something is updated. In the update tests, we return what the entity looks like before it is updated so we set the create and modified time 5 days earlier so that we can then ensure that the modified time gets updated to the mocked datetime. Let me know if this does not make sense and I will talk to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
created_timeandupdated_timefields to catalogue categories, catalogue items, items, manufacturers and systems.Draft as tests need updating.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #100