Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll and prepare queued Downloads #38 #45

Open
wants to merge 5 commits into
base: 36_queuing
Choose a base branch
from

Conversation

patrick-austin
Copy link

@patrick-austin patrick-austin commented Nov 25, 2024

Branched from #39 due to those test failures breaking the tests added as part of this PR.

  • Add run.properties setting for the maximum number queued jobs to schedule concurrently
  • After existing updateStatuses check, startQueuedDownloads up to the limit above - and RESTORING Downloads
  • Refactor existing query in updateStatuses for clarity
  • Re-enabled StatusCheckTest in pom.xml
  • Removed references to em in StatusCheckTest and use the downloadRepository instead, like the other tests
    • Mostly this did not require changes to any test logic, just the utility functions, but did alter updates to Downloads in the tests to either create with those values in the first place or explicitly create new Downloads
  • Tests in StatusCheckTest now use finally to remove Downloads created for the test, as failure in one test meant bad data caused subsequent tests to fail
  • Changes to how the dummy Downloads are created to support arbitrary preparedIds and statuses, for testing the new functions
  • Whitespace changes caused by auto-formatting my changes (tried to limit this to only functions relevant to this change)

Closes #38

@patrick-austin patrick-austin marked this pull request as ready for review November 27, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant