Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect related entity references #227

Closed
1 task
MRichards99 opened this issue Apr 26, 2021 · 3 comments
Closed
1 task

Fix incorrect related entity references #227

MRichards99 opened this issue Apr 26, 2021 · 3 comments
Labels
bug Something isn't working db backend Issues relating to the DB backend wontfix This will not be worked on

Comments

@MRichards99
Copy link
Collaborator

Description:
Last week, I noticed some of the foreign key references don't match the ICAT schema on DB backend. In particular, type (related entity from investigation to investigation type) could only be referenced using INVESTIGATIONTYPE (it seemed to be case insensitive actually). These foreign key references should be checked and modified to match the ICAT schema.

This is part of the work for #213

Acceptance criteria:

  • Related entity references should match ICAT schema (and therefore ICAT backend) - this is most easily tested with include filters on GET requests of the different entities
@MRichards99 MRichards99 added bug Something isn't working db backend Issues relating to the DB backend labels Apr 26, 2021
@MRichards99 MRichards99 mentioned this issue May 17, 2021
Merged
4 tasks
@MRichards99 MRichards99 self-assigned this May 17, 2021
MRichards99 added a commit that referenced this issue May 17, 2021
@MRichards99
#227: Add basis of DB related entity tests
a9a45eb
MRichards99 added a commit that referenced this issue May 17, 2021
@MRichards99
#227: Speed up entity relationship tests
77629ec
MRichards99 added a commit that referenced this issue May 17, 2021
@MRichards99
#227: Add remaining test cases
b91f035 
- There's a lot of failures to resolve...
MRichards99 added a commit that referenced this issue May 17, 2021
@MRichards99
#227: Add remaining test cases
7fbda14 
- There's a lot of failures to resolve, 26 so far, with 6 warnings on top of that...
MRichards99 added a commit that referenced this issue May 17, 2021
@MRichards99
#227: Look for related entities instead of just testing 1st result
61ff4a4 
- Down to 22 fails, still 6 warnings
MRichards99 added a commit that referenced this issue May 20, 2021
@MRichards99
#227: Fix TYPE and other simple related entity names
1e58abb 
- Down to 13 fails, 6 warnings for no data
MRichards99 added a commit that referenced this issue May 21, 2021
@MRichards99
#227: Fix TYPE and other simple related entity names
940a829 
- Down to 13 fails, 6 warnings for no data
@MRichards99
Copy link
Collaborator Author

Unassigning myself as this won't be tackled in the short term.

@MRichards99 MRichards99 removed their assignment Feb 23, 2022
@MRichards99 MRichards99 added the wontfix This will not be worked on label Mar 17, 2022
@MRichards99
Copy link
Collaborator Author

Adding the wontfix label to this issue - there's no plans to work on this issue for the time being and because the DB backend won't be used in production, this is a low priority, potentially high effort issue.

@MRichards99
Copy link
Collaborator Author

DB backend to be removed as per #489

@MRichards99 MRichards99 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working db backend Issues relating to the DB backend wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MRichards99