Put the update request form in the request detail page, so that updates can be made there, and hence removed the update request buttons from the main request table. #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syncing with the original repo
Syncing with the original repo
removed the update column in the main requests table
biswaz
reviewed
Aug 23, 2018
.gitignore
Outdated
| @@ -5,6 +5,8 @@ __pycache__ | |||
| .env | |||
| staticfiles/ | |||
| mysite.log | |||
| settings.py | |||
There was a problem hiding this comment.
Please don't do this.
(Thank GOD I'm not Linus Torvalds 😄 )
There was a problem hiding this comment.
My bad :33, I did it for my convenience, forgot to change back.
Just fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference
This PR addresses the Issue : Fixes #880
Summarize
Any update to any request can now be made from the details page of that request, hence the update button is no longer necessary, and hence removed the update column from the main requests table, making that page less cluttered, changed the name of the more details column to "More Details/ update the request" in English and in Malayalam- changed the name of the More detail buttons to More details / update