Show request details in popup modal #750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanavas786
force-pushed
the
req-summary
branch
from
5295862
to
0c29808
Compare
|
sample |
shidhincr
reviewed
Aug 20, 2018
| const iDate = 5 | ||
| const iGps = 6 | ||
| const iSummary = 7 | ||
|
|
||
| window.onload = function() { |
There was a problem hiding this comment.
Since we use jQuery, change this window.onload to
$(window).on('load', function(){
})There was a problem hiding this comment.
Thanks,
But we can't do that because jquery script is loaded at the bottom of the page. using $ would through an error
There was a problem hiding this comment.
Ah okay..
Then changing it to window.addEventListener would be good enough. I saw in other places window.onload is been used. It will cause the onload overridden from other places.
There was a problem hiding this comment.
chaged to window.addEventListener, though overriding won't be an issue as only one template is loaded at a time
|
@shanavas786 please resolve conflicts as well. |
shanavas786
force-pushed
the
req-summary
branch
from
d8e2d8c
to
280d348
Compare
|
done |
realslimshanky
approved these changes
Aug 23, 2018
Use eventlistener instead of onload
shanavas786
force-pushed
the
req-summary
branch
from
b795c6b
to
7836017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference
This PR addresses the Issue : Closes #626
Summarize
By handling request detail in request list page itself, we can reduce hits to request details api