Don't publish rainlang_test_fixtures (unblocks Package Release autopublish) - #532
Don't publish rainlang_test_fixtures (unblocks Package Release autopublish)#532thedavidmeister wants to merge 1 commit into
Conversation
…blish) rainlang_test_fixtures is a path dev-dependency of cli/eval tests only — it is never resolved from crates.io, and its sol! macros read ABI JSON from the sibling bindings crate via ../bindings/abi paths, so it cannot build standalone in a cargo-published tarball. It was included in the autopublish lockstep set, so `cargo publish` failed verifying its tarball (28 sol! type-resolution errors), and because the release job runs cargo before soldeer fail-fast, that aborted the run before the soldeer package published. Mark the crate publish = false and drop it from the package-release crates list so the autopublish can publish the other four crates and the soldeer package. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 24 minutes and 33 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Wrong approach — |
1 participant
Problem
The
Package Releaseautopublish onmainhas been failing at Publish to crates.io, which aborts the job before the soldeer package publishes (the reusable runs cargo → soldeer fail-fast). Sorainlangsoldeer releases are stuck (the registry is behindmain), which blocks a downstream consumer (raindex) waiting on a newrainlangsoldeer version.Root cause:
rainlang_test_fixturescannot build standalone in cargo's tarball verification — itssol!macros read ABI JSON via../bindings/abi/*.json(paths outside its own crate), which aren't packaged when the crate is published, so the generated types (Deployer,ERC20,Interpreter,Store,Parser) are undeclared → 28 compile errors →failed to verify package tarball.Why
publish = falseis correctrainlang_test_fixturesis a path dev-dependency ofcliandeval([workspace.dependencies.rainlang_test_fixtures] path = "crates/test_fixtures", used under[dev-dependencies]). Nothing resolves it from crates.io — published consumers ofeval/clidon't pull dev-dependencies. It is test infrastructure, not a release artifact, and was only in the lockstep set by oversight (it never actually published, since it can't build standalone).Change
crates/test_fixtures/Cargo.toml:publish = false..github/workflows/package-release.yaml: droprainlang_test_fixturesfrom thecrates:list (and correct the now-stale lockstep comment).This lets the autopublish publish the remaining four crates and the soldeer package. No effect on local builds or tests —
publishdoes not affect path dev-dependency usage.🤖 Generated with Claude Code