eval: use crates.io rain-error-decoding 0.1.2 instead of git - #522
Conversation
The rain-interpreter-eval crate is consumed by downstream repos (raindex) as a git dependency. Pinning rain-error-decoding to a git rev meant those consumers got a parallel copy of the crate, distinct from the published crates.io 0.1.2 — so AbiDecodedErrorType failed to unify across the eval API boundary. 0.1.2 is the published equivalent of rev 3d2ed70, so this is a no-op for behaviour and lets consumers share a single rain-error-decoding. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR migrates the workspace dependency ChangesDependency Migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
rain-interpreter-evalis consumed downstream (raindex) as a git dependency. Pinningrain-error-decodingto a git rev meant those consumers pulled a parallel copy of the crate, distinct from the published crates.io0.1.2— soAbiDecodedErrorTypefailed to unify across the eval API boundary (raindex'sForkCallRevertedcouldn't accept eval'sAbiDecodedError).0.1.2is the published equivalent of rev3d2ed70, so this is behaviour-neutral.cargo check -p rainlang-evalpasses against it. This lets crates.io consumers share a singlerain-error-decoding.Part of removing git deps from the raindex dependency graph (raindex#2593).
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
rain-error-decodingdependency to version 0.1.2, replacing the previous Git-sourced version for improved stability and maintainability.