Skip to content

bump up alloy-ethers-typecast#339

Closed
0xgleb wants to merge 1 commit into
mainfrom
upd/alloy-ethers-typecast
Closed

bump up alloy-ethers-typecast#339
0xgleb wants to merge 1 commit into
mainfrom
upd/alloy-ethers-typecast

Conversation

@0xgleb

@0xgleb 0xgleb commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

Caution

Merge rainlanguage/alloy-ethers-typecast#54 first and update the specified revision

Motivation

We need the update in rainlanguage/alloy-ethers-typecast#54 to use Alloy built-in multicall functionality but that makes the versions of alloy-ethers-typecast incompatible between the orderbook and the interpreter

Solution

Bump up alloy-ethers-typecast version

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Summary by CodeRabbit

  • Chores
    • Updated a dependency to a newer revision.
    • Adjusted import paths for certain components to reflect changes in the updated dependency. No changes to app functionality or user-facing features.

@coderabbitai

coderabbitai Bot commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The changes update the alloy-ethers-typecast dependency to a newer commit and adjust import paths throughout the codebase to reflect a relocation of several types from a submodule to the crate root. No logic or functionality is altered.

Changes

File(s) Change Summary
Cargo.toml Updated alloy-ethers-typecast dependency to a new commit hash.
crates/dispair/src/lib.rs Changed imports of several types from alloy_ethers_typecast::transaction to alloy_ethers_typecast.
crates/parser/src/error.rs, crates/parser/src/v2.rs Updated import paths for types from the transaction submodule to the root of alloy_ethers_typecast.

Possibly related issues


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e09c37 and 9b4b66c.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • Cargo.toml (1 hunks)
  • crates/dispair/src/lib.rs (1 hunks)
  • crates/parser/src/error.rs (1 hunks)
  • crates/parser/src/v2.rs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: rainix (ubuntu-latest, test-wasm-build)
  • GitHub Check: rainix (ubuntu-latest, rainix-rs-static)
  • GitHub Check: rainix (macos-latest, rainix-rs-artifacts)
  • GitHub Check: rainix (ubuntu-latest, rainix-sol-artifacts)
  • GitHub Check: rainix (ubuntu-latest, rainix-sol-test)
  • GitHub Check: rainix (ubuntu-latest, rainix-sol-static)
  • GitHub Check: rainix (ubuntu-latest, rainix-rs-artifacts)
  • GitHub Check: rainix (ubuntu-latest, rainix-rs-test)
  • GitHub Check: rainix (macos-latest, rainix-rs-test)
  • GitHub Check: git-clean
🔇 Additional comments (4)
Cargo.toml (1)

35-35: ```shell
#!/bin/bash

Fetch default branch of the repository

default_branch=$(curl -s https://api.github.com/repos/rainlanguage/alloy-ethers-typecast | grep '"default_branch"' | sed -E 's/."default_branch": "(.)".*/\1/')
echo "Default branch: $default_branch"

Check if the target commit is part of the default branch

git ls-remote https://github.com/rainlanguage/alloy-ethers-typecast.git | grep "6476f8fee685c1ab3c39dd3ded1b33b769223e6a" | grep "refs/heads/$default_branch" &&
echo "Commit is on the default branch." ||
echo "Commit is NOT on the default branch."


</details>
<details>
<summary>crates/parser/src/error.rs (1)</summary>

`1-1`: **Approve updated error imports**  
`ReadContractParametersBuilderError` and `ReadableClientError` are now correctly imported from the crate root, reflecting the new re-exports.

</details>
<details>
<summary>crates/parser/src/v2.rs (1)</summary>

`3-3`: **Approve import path adjustment**  
`ReadContractParametersBuilder` and `ReadableClient` imports are updated to the crate root, matching the relocated exports in the bumped version.

</details>
<details>
<summary>crates/dispair/src/lib.rs (1)</summary>

`2-5`: **Approve consolidated transaction imports**  
All `ReadContractParametersBuilder`, `ReadContractParametersBuilderError`, `ReadableClient`, and `ReadableClientError` types are now imported directly from `alloy_ethers_typecast`, aligning with the new crate structure.

</details>

</blockquote></details>

</details>
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKNxU3bABsvkCiQBHbGlcABpIcVwvOkgAIgFHbkhsJLQffFkwElxYSkQwXFluUTREMNjIAHdS+2wBZnUaejlkxEpIAAYADyJogXRkW0gMRwF2gGZxgE4ULBySP20ML0wibDRSAHoqeAwNXZoKXmz2/258RHV8Fw0YXMhmJZ5sI4uF/AAzCPuh1AJk7i0agLeaQKQUS74LCfb4LAAGaS8GSy8whBSKJTKcMgSmKGCUGAY8mwbXou1hs0Ox0Ot3cyBSQJoKGQ5AY0kQznk/12TFeVCZDFgq2kkA+FBY6D8JBWTWsdgAFLBcLhuIgOJtNkR1LA6homMxtksVhg1hsSJtEcjsrk0YVigxSrhNp4fJsAKwAFgAlN9qJTxbRsGzkABBdKyADkMmw8C8uDA5OY3nEDp8ouwhPEULS6lktwAEvhKiRweEcqhyJV05n4NmvLnGGgSSLwZCsDyWNxqPA1PXCpAxrhi2QKdclBQBPh8ABrdD4ikHSjU9r687kDC4RC0/BSxD4LxSb5IMs/OwJZiqikI8Mom35O2Y3DY1u1uY7x4HJ6r7u93MaNz3E2OTXMM+A0MgOR+qC/gfJQZBsvQvxzIBN7Wnk6L2o6UrnJcBAuA8JK4AOCxsBQpD0B88AQkRYwfNcCwMt2JoUv4EhIK+sxHoMNi0vcDj1EgbYKBglEUMwEFCkRoK/Mg04kNwRE1IgjxpjUOGXAI0ThDyXjYEo9IYOoEQhMgdF8Jg8iVtWYivjmhThPWGDTsg/jRBImBEYJwTICBtiIOEmBkoSun6fYDD+GQiCwGByDwF8aDcNw9YOppJC8QsQzaOJEQ7pFLwLEwGCXGU7BzvQ37iKlrRmvwXygteSKZGhtoYg6WI8GgDDTjVnXiogEkLLw+AiGICgXlC7BbkY+jGOAUBkPQMJAYQpDkPyMT6mwG5cLw/DCKI4hSDI8hMOOKhqJo2i6GAhgmFAdLMnOOAEMQZDKLKm3sFwVBVg4Tj4S0p3KKo6haDoM2zaYBgAMLOEQ+AaAQzBeBwBixOjBgWJAIYAJKvWtwL0H9jz4TCgrCogAELLiC3wfIrHsVCoogfVlpNai96tY62LhcCVQ1IxspihKm1GXCHwAOwCG6AgfLQHQAGwABwSx8ACMCsMBLEu0LLtC0B6UwdDLABMHrjB6EtTOMHxoBLStK262L/HCCuWwrHxK7BJDK26DBqyo4wMNM+vjEotBqwIkwCBLCtTCbJvjD7aDYuSoKVNczldmyOLybThLwCKbQ2UzML1bDZEI0jXjYpR0S3AAcjuYE2owQomiK/w0/i8GFz5fCFZRaz8hxxb+A8aBKP+RiY5YYaHN2UIQTuoJKAwKwj0vtWQCQXTnBQsogZ4mnwAwO8buofdGE35D/ujsTTVDvPgZstBIF2VGbIgFAMJs9YCBoCEqN76z2xnjVa70YjE05NvcmHdKYGDgAseA40D72FwMCLaREzKQDhDYEgk9oZQlwFQMQVhnBoDYIcRAAAhGMXhxxwnCHgghtAiEblIbgchVAqF5DobGccABRCg4oKBMNwfgyeKhojQ3rOwcRgUJGsOkSQWRhcNzCNEdiaoyA4HkVFOKZgKBUHiGYoge0cVT6InkMLIx9USGYA5CXDA2J+LMEUN4d4XwGoZAAPrNUQL4h8bUnw5WMfvUxRAcRUQOl4GxhiWJTiIjCHxsh/EcyCVzLEvFUDuLfpRTufF8AvBzl2HI295htBQDQbKCQiK0HwCKDAYE27CjnPIJEWoz4gQ+BmZxdl5Bp3uEDae5g55xneq+ZeFI14b0XkVbeu8IkxCPnUZK59IhXwMDfNKaMMYGAgGAIwz9pDOmcG0CgX8f6bEoKIwBao9kPyxrjfGkCiaOBJvIMm7dSAIKQeE64REymwGZnwFhhDiGcO4ZQk4EJ+EMMoJo642JFHgqBKlNR7AkViP5ron5MRbHEV2FE8gJV6AZnHLgtm6S7yZMwmUDgHAHFFU6lmFxYS37+DEHE5IPcwXUoCXSx8cJG7N1RAoJQ/A+CdNPq0+BVQ4ITynjPUB89Jlb3+KvUQcy2U+S+EswFKy+DH3WewS+0hr4TUeY/I5BgTmIDORCSgVzf4SBNvc4BGNnngLeutd5/0vlfD0RaxB9wUERPQZg0qOC0XsIcWQihvC4X0MYWVJRUiMVyI3NomowaKIJPDYC4lsIqkPmQOY0QljUw8sJfYqgLLnGuLqHkzx29Uk0ryEKkJzsdyFoPsW+YRjOWxPiRKaCSS20CoycE7mor+DiqBlKyAMqz7BuQGPEik9dkz2eRMzeCzNX3FmRQ3Viy96GsWsatZsqzXiBDTsu++yIZ3XPoteKeAVq+sJmNLB300C/Q+TAwGihgYXTBtdW6c0f3qF8fAWggSGYkGLLQXxZRnBEWfVBqYAgPQCAVprJWJAPhujNuMN0CtxjS01jbCWHQBBTEdkbfWJs44MC9gsTDEBoO4Fg/B3xiHkP+PnPoIAA=== -->

<!-- internal state end -->
<!-- finishing_touch_checkbox_start -->

<details open="true">
<summary>✨ Finishing Touches</summary>

- [ ] <!-- {"checkboxId": "7962f53c-55bc-4827-bfbf-6a18da830691"} --> 📝 Generate Docstrings

</details>

<!-- finishing_touch_checkbox_end -->
<!-- tips_start -->

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

<details>
<summary>❤️ Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=rainlanguage/rain.interpreter&utm_content=339):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Explain this complex logic.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai explain this code block.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and explain its main purpose.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

### Support

Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### CodeRabbit Configuration File (`.coderabbit.yaml`)

- You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.
- Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json`

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

@0xgleb
0xgleb requested review from findolor and hardyjosh June 18, 2025 17:30
@0xgleb
0xgleb marked this pull request as ready for review June 18, 2025 17:30
@0xgleb 0xgleb closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant