docs(append-only): state the rule, not the incident that produced it - #351
Conversation
The comment narrated a specific repo's file names, a specific commit, the date it landed and what CI reported at the time. None of that tells a reader what the predicate does or why it is shaped that way; git carries it, and the issue and PR carry the argument. What survives is the reasoning that still constrains the code: why the test is on the directory rather than a filename inside it (a naming mismatch makes the gate skip, and a skip is indistinguishable from a pass), and why the delete-everything hole is left open (closing it needs the base branch, which would mean fetching in every sol repo in the org). Comment only; no behaviour change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 51 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
1 participant
The
frozen-snapshots-append-onlycomment narrated a specific repo's file names, aspecific commit, the date it landed and what CI reported at the time. None of that tells a
reader what the predicate does or why it is shaped that way — git carries it, and
#341 and #343 carry the argument.
What survives is the reasoning that still constrains the code:
makes the gate skip wherever the generator's naming differs from the assertion, and a
skip is indistinguishable from a pass.
removing every snapshot switches off the check that would catch the removal. Closing it
needs the base branch, which would mean fetching in every sol repo in the org, including
the ones whose default branch is not
main.21 lines removed, 16 added. Comment only.
QA
#comment lines inside a compositeaction's
run:block. No shell statement, no condition and no command is touched, sothere is no behaviour for a test to discriminate. Verified by inspection of the diff:
every changed line begins with
#after its indentation, and the surroundingif [ ! -d src/generated ]guard, the fetch block and thenix runinvocation arebyte-identical.
comment describes was mutation-covered when it was written (fix(tag-release): determinism check that never removes the frozen record #343).
consumers have git. A comment's job is to say what the code does and why it is shaped
that way, not to record how it came to be that way.
file names, the commit hash, the date and the CI-reported-success anecdote are gone; both
live constraints are kept and stated as rules rather than as consequences of an incident.
🤖 Generated with Claude Code