Revert entire v5 branch to a044f50f - #2517
Conversation
v5.raindex.finance was broken because the 2025-12-18-exact-swap PR (#2366) merged V6 OrderBook bindings into main, which the v5 branch inherited. This caused calldata for withdraw4/deposit4/addOrder4 (IOrderBookV6) to be generated, while deployed contracts on v5 only implement withdraw3/ deposit3/addOrder3 (IOrderBookV5). Full revert to a044f50 (NPM Package Release v0.0.1-alpha.201), the last clean V5 state on main before #2366 landed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure the |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The fuzz test was etching random token addresses including the TOFU decimals singleton address (0x4f1C29...), which overwrites it with REVERTING_MOCK_BYTECODE. This caused deposit3 to fail when calling decimalsForToken on the now-broken singleton. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Closing this in favor of a clean-history reset plan. We created a new branch, Plan from here:
Because of that, we are not merging this PR. This PR was useful to validate the rollback target and confirm the affected surface area, but the actual recovery path is to rebuild from the clean base branch rather than merge a revert commit onto |
Summary
v5branch to commita044f50f(NPM Package Release v0.0.1-alpha.201) — the last clean V5 state onmainbefore PR wip on exact swap #2366 (2025-12-18-exact-swap) landedmain, whichv5inherited, causingv5.raindex.financeto generate calldata forwithdraw4/deposit4/addOrder4(IOrderBookV6) while deployed contracts only implementwithdraw3/deposit3/addOrder3(IOrderBookV5)lib/rain.orderbook.interface→dae86d795,lib/rain.interpreter→18827b5af,lib/rain.tofu.erc20-decimals→ca8e8bacf)Test plan
withdraw3on v5.raindex.financedeposit3addOrder3🤖 Generated with Claude Code