Skip to content

Fix npm release workflow failures - #2422

Merged
findolor merged 6 commits into
mainfrom
2025-01-29-npm-release-workflow-fix
Jan 29, 2026
Merged

Fix npm release workflow failures#2422
findolor merged 6 commits into
mainfrom
2025-01-29-npm-release-workflow-fix

Conversation

@findolor

@findolor findolor commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Motivation

The npm release workflow has been failing for approximately two months due to multiple issues:

  1. Missing repository field: The ui-components package.json was missing the repository field, causing npm OIDC publish to fail with a 422 error (npm requires the repository URL to match the git remote for provenance attestation)

  2. Version mismatch: Package versions in the repo (0.0.1-alpha.197) were out of sync with what's actually published on npm (0.0.1-alpha.196), causing dependency resolution failures during CI

  3. Swap file creation: The swap file creation step could fail with "Text file busy" if the file already existed from a previous run

Solution

  • Add repository field to packages/ui-components/package.json to match the orderbook package configuration
  • Reset both package versions to 0.0.1-alpha.196 to match what's published on npm, allowing the workflow to properly bump and publish
  • Fix swap file creation to check for existing file and remove it before creating a new one

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Summary by CodeRabbit

  • Chores
    • Downgraded package versions to 0.0.1-alpha.196
    • Added repository metadata to package configuration
    • Improved swap file management in build infrastructure

✏️ Tip: You can customize this high-level summary in your review settings.

@findolor findolor self-assigned this Jan 29, 2026
@findolor findolor added this to the v5 final prs milestone Jan 29, 2026
@findolor
findolor requested review from 0xgleb and hardyjosh January 29, 2026 14:21
@coderabbitai

coderabbitai Bot commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The PR updates CI/CD workflow configuration and package manifests, including enhanced swapfile management in the npm release workflow and version rollbacks across related packages with repository metadata additions.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/npm-package-release.yml
Adds a pre-step to conditionally remove existing /swapfile before creating a fresh 8GB swapfile, improving swap space initialization.
Package Metadata Updates
packages/orderbook/package.json, packages/ui-components/package.json
Version rollback from 0.0.1-alpha.197 to 0.0.1-alpha.196 across both packages; adds repository metadata (git type and GitHub URL) to ui-components.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

general update

Suggested reviewers

  • hardyjosh
  • 0xgleb
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the primary change: fixing npm release workflow failures by addressing missing repository field, version mismatches, and swap file handling issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@findolor
findolor merged commit 5208d74 into main Jan 29, 2026
19 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

@coderabbitai

coderabbitai Bot commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

The author of this PR is on the CodeRabbit Free Plan. In order to use the Chat feature, please upgrade the PR author to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

@coderabbitai coderabbitai Bot mentioned this pull request Jan 31, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants