Skip to content

ci: rename git-clean job id to git-clean (closes #37) - #38

Merged
thedavidmeister merged 1 commit into
mainfrom
2026-08-27-issue-37-git-clean-job-id
Aug 27, 2026
Merged

ci: rename git-clean job id to git-clean (closes #37)#38
thedavidmeister merged 1 commit into
mainfrom
2026-08-27-issue-37-git-clean-job-id

Conversation

@thedavidmeister

@thedavidmeister thedavidmeister commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Renames the git-clean.yaml job id from copy-artifacts to git-clean. The file is already git-clean.yaml and the workflow is already name: Git is clean, so the job id is the only one of the three names this repo still had wrong — one line.

The job id is what shows in the checks list, so it is the name a reviewer actually reads on a PR.

The reusable workflow in the uses: line is deliberately unchanged: rainlanguage/rainix/.github/workflows/rainix-copy-artifacts.yaml@main. rainix defines that one rather than consuming it, and renaming it would break every consumer.

Branch protection checked, nothing to update. Renaming a job silently unrequires a required context, so this was verified before the rename rather than assumed: main has no classic branch protection (HTTP 404), and GET /repos/rainlanguage/rain.pyth/rules/branches/main returns [], which covers org-inherited rulesets as well as repo-level ones. There is no required copy-artifacts context to strand, so no protection rule needs changing alongside this PR.

QA

  • Discriminating tests: n/a — no test in this repo asserts on workflow job ids, and the executable check is the workflow itself. The discriminating evidence is GitHub's own checks list on this PR, which reads git-clean / ... on this branch where it reads copy-artifacts / ... on base.
  • Mutations applied: n/a — a one-line CI identifier rename has no behavioural line to mutate. The rename is itself the mutation and Actions is the killing check: an invalid or duplicated job key fails workflow parsing outright rather than passing quietly. The uses: line was diffed to confirm it is byte-identical, since renaming it there is the one change that would break the call.
  • Oracle: the standard as stated in Standardise the currency check on git-clean (file, workflow name and job id) #37 — file .github/workflows/git-clean.yaml, workflow name: Git is clean, job id git-clean — and the two repos already fully conformant to it, rain.solver and rain.uniswap. Independent of anything this diff asserts about itself.
  • Category check: the issue asks for three names (file, workflow name, job id). The file and workflow name were confirmed already conformant by reading this repo's git-clean.yaml rather than trusting the issue's summary, so job id is the only one this PR covers; all three hold after it.

Closes #37

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Renamed an internal automation workflow job for clearer identification.

The job id is the name that shows in the checks list. The file and
workflow name were already standard; this is the third name.

The rainix reusable workflow in the uses: line is unchanged.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fcc67e20-df16-4ca0-8775-6728d1e90a90

📥 Commits

Reviewing files that changed from the base of the PR and between 9f9cd8c and 520467b.

📒 Files selected for processing (1)
  • .github/workflows/git-clean.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The workflow job identifier changes from copy-artifacts to git-clean. The reusable workflow and inherited secrets remain unchanged.

Changes

git-clean workflow naming

Layer / File(s) Summary
Rename workflow job identifier
.github/workflows/git-clean.yaml
The job identifier changes from copy-artifacts to git-clean. The reusable workflow and secrets: inherit remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 52046

This is a one-line CI naming correction that does not change the workflow implementation or reusable workflow reference, so no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the job ID rename and references linked issue #37.
Linked Issues check ✅ Passed The PR updates the job ID to git-clean as required by issue #37. The file name and workflow name already conform, and the reusable workflow reference remains unchanged.
Out of Scope Changes check ✅ Passed The PR contains only the required job ID rename. It does not change the reusable workflow or introduce unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-08-27-issue-37-git-clean-job-id

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thedavidmeister
thedavidmeister merged commit 9ea145f into main Aug 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardise the currency check on git-clean (file, workflow name and job id)

1 participant