Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utilize new yaml structure #374

Merged
merged 59 commits into from
Mar 15, 2024
Merged

utilize new yaml structure #374

merged 59 commits into from
Mar 15, 2024

Conversation

rouzwelt
Copy link
Contributor

@rouzwelt rouzwelt commented Mar 1, 2024 •
edited by mattyg
Loading

resolves #369

  • slightly refactor ConfigString
    • now takes actual types (i.e. serde deserialization finds type errors, so we don't have to catch them manually when converting ConfigString -> Config)
    • custom types for "foreign key" reference types for clarity
    • all structs are now serialized/deserialized to kebab-case, to match the spec
  • settings page now handles new config structure, displays parsing errors as codemirror problems
  • add order editor now handles new config structure in frontmatter, displays parsing errors as codemirror problems, includes deployment dropdown
  • switch to fork of typeshare, with this PR merged ( Allow overrides for disallowed types (e.g. 64 bit integers) 1Password/typeshare#140 ) to allow support for u64 types in typescript
    • remove no longer needed typeshareFix.cjs script

@rouzwelt rouzwelt added the enhancement New feature or request label Mar 1, 2024
@rouzwelt rouzwelt self-assigned this Mar 1, 2024
@rouzwelt rouzwelt changed the title new yaml structure utilize new yaml structure Mar 1, 2024
@hardyjosh hardyjosh linked an issue Mar 2, 2024 that may be closed by this pull request
update tauri yaml parsing to point to new yaml structs #369
Closed
mattyg
mattyg reviewed Mar 4, 2024
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
@mattyg mattyg changed the title WIP - utilize new yaml structure utilize new yaml structure Mar 14, 2024
@mattyg mattyg requested a review from hardyjosh March 14, 2024 19:12
@thedavidmeister thedavidmeister mentioned this pull request Mar 15, 2024
Closed
@mattyg mattyg enabled auto-merge March 15, 2024 19:36
@mattyg mattyg merged commit ec40f68 into main Mar 15, 2024
9 of 10 checks passed
@mattyg mattyg deleted the 2024-02-29-new-yaml-structure branch March 15, 2024 20:02
@mattyg mattyg restored the 2024-02-29-new-yaml-structure branch March 19, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattyg mattyg mattyg left review comments

@hardyjosh hardyjosh hardyjosh approved these changes

@thedavidmeister thedavidmeister thedavidmeister approved these changes

Assignees

@rouzwelt rouzwelt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update tauri yaml parsing to point to new yaml structs
4 participants
@rouzwelt @mattyg @thedavidmeister @hardyjosh