config: drop the inherited ./meta fs permission, refresh the stale .gas-snapshot - #3
Conversation
Nothing here is rain-meta aware and there is no ./meta directory: the only filesystem access this repo needs is BuildPointers reading foundry.toml and writing src/. .gas-snapshot still described rain.factory's pre-0.1.5 clone() suite — CloneFactoryCloneTest and its six tests do not exist in this repo, and the tagged-constants suite was missing. Regenerated over the offline suites. The package-release comment pointed at a generated DEPLOY_TAG; this repo generates none, its release artifact is the src/generated/<tag>/ snapshot.
|
Warning Review limit reached
Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed ac45d5b: approve Config-accuracy half of the post-split sweep (docs half merged as #2):
Correctly split from #2: that one is pure prose, this changes build config plus a checked-in artifact — different blast radius, different review surface. Red check verified and NOT caused by this diff: rainix-sol/test fails on exactly one test, testProdDeployArbitrum, with 'lb.drpc.live … error code -32001: You've reached the usage limit for your current plan' — 19/20 pass. That is the exhausted drpc quota on RPC_URL_ARBITRUM_FORK blocking several repos today; it needs a human RPC swap, and was not rerun or chased. static + legal green; no unresolved threads. |
Companion to #2, kept separate because that PR is prose only (
README.md+CLAUDE.md) and this one touches build config, a checked-in artifact and a workflow comment — different blast radius, different thing to check when reviewing.Same sweep, same cause: the genesis split (rainlanguage/rain.factory#46) copied
rain.factory's config wholesale, and some of it describes a repo this is not.foundry.toml—fs_permissionson./metaThere is no
./metadirectory, no rain-metadata dependency and no meta-aware contract in this repo — the comment describes a capability that does not exist here. The only filesystem access anything needs isscript/BuildPointers.solreadingfoundry.tomland writingsrc/, which the two remaining entries already grant. Verified after removal:forge script ./script/BuildPointers.sol && forge fmtstill regeneratessrc/generated/0_1_5/andsrc/lib/LibCloneFactoryDeploy.solbyte-identical (cleangit status), andforge testis unchanged..gas-snapshot— described a test suite that no longer existsEvery fuzz entry named
CloneFactoryCloneTest:testCloneBytecode/testCloneInitializeData/testCloneInitializeEvent/testCloneInitializeFailureFails/testCloneUninitializableFails/testZeroImplementationCodeSizeError. That contract and those tests arerain.factory's pre-0.1.5clone()suite, deleted whenclone()was dropped for deterministic-onlyICloneableFactoryV3; this repo's suite isCloneFactoryCloneDeterministicTest.LibCloneFactoryDeployTaggedConstantsTestwas missing entirely. Regenerated withforge snapshotover the offline suites (theLibCloneFactoryDeployProdTestfork tests are excluded — they were never in the file, and their gas is fork RPC noise).Note the file is a convention (25 org repos carry one) but nothing in rainix CI reads it — see the ruling question in my report about whether it earns its keep.
package-release.yamlcomment —DEPLOY_TAGSame false claim #2 fixes in the README: this repo generates no
DEPLOY_TAGconstant. Its release artifact is the frozensrc/generated/<tag>/snapshot. Comment only, no workflow behaviour change.Checked here, deliberately not touched
REUSE.toml,.soldeerignoreand.coderabbitai.yamlall still listaudit/**paths that #1 removed — left as-is, because those files already list.gitmodules/foundry.lock//metathat have never existed here either: they are defensive ignore/annotate lists, not claims about repo contents, andreuse lintis green (28/28 files). The rest offoundry.tomlverified accurate: package namerain-factory-deploymatchessoldeer-packagein the release workflow,[dependencies] rain-factory = "0.1.5"is the latest published version (0.1.6in rain.factory'sfoundry.tomlis its unpublished next-version slot), and the five[rpc_endpoints]/[etherscan]networks matchLibRainDeploy.supportedNetworks().Verification
nix develop github:rainlanguage/rainix/53e96a7d0a97d7c7c75c3b2412521324776fdac6#sol-shell -c bash -c 'forge soldeer install && forge build && forge test'— build clean, 15/20 pass; the 5 failures are theLibCloneFactoryDeployProdTestfork tests with no local*_RPC_URLenv.forge fmt --checkpasses,reuse lintpasses, pins regenerate byte-identical.Known CI red, not caused by this PR:
rainix-sol/testfails ontestProdDeployArbitrumwithvm.createSelectFork ... lb.drpc.live ... error code -32001: You've reached the usage limit for your current plan. The org secretRPC_URL_ARBITRUM_FORKpoints at an exhausted drpc endpoint; it needs a human RPC swap and is red on other org repos today. 19/20 pass.staticandlegalare green.