Skip to content

style(pragma): pin all non-generated source/test files to =0.8.25 - #225

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-06-24-issue-55-pragma-pinned
Open

style(pragma): pin all non-generated source/test files to =0.8.25#225
thedavidmeister wants to merge 1 commit into
mainfrom
2026-06-24-issue-55-pragma-pinned

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Closes #55

The repo mixed ^0.8.25 (floating) in most src/ libs and two test utils with =0.8.25 (pinned) in src/concrete/ERC4626Words.sol and all test/src/ files. foundry.toml fixes solc = "0.8.25" so the floating ranges never resolve to anything else, but the inconsistency is confusing and violates a uniform style convention.

What changed

9 non-generated files changed: pragma solidity ^0.8.25pragma solidity =0.8.25.

src/generated/ERC4626Words.pointers.sol retains ^0.8.25 — its header is emitted by rain-sol-codegen's LibFs.buildFileForContract template and cannot be changed in-repo.

Closes #55

Remaining floating pragma in src/generated/ERC4626Words.pointers.sol is
controlled by the upstream rain-sol-codegen LibFs.buildFileForContract
template and cannot be changed in-repo.
@thedavidmeister thedavidmeister self-assigned this Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thedavidmeister, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 56 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f6be3c4d-35b5-4a45-8e54-029e4e8d1730

📥 Commits

Reviewing files that changed from the base of the PR and between 7415942 and 006183d.

📒 Files selected for processing (9)
  • src/abstract/ERC4626Extern.sol
  • src/abstract/ERC4626SubParser.sol
  • src/lib/erc4626/LibERC4626.sol
  • src/lib/op/erc4626/LibOpERC4626ConvertToAssets.sol
  • src/lib/op/erc4626/LibOpERC4626ConvertToShares.sol
  • src/lib/parse/LibERC4626SubParser.sol
  • test/utils/MaliciousERC4626.sol
  • test/utils/MockERC20.sol
  • test/utils/MockERC4626.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-06-24-issue-55-pragma-pinned

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thedavidmeister thedavidmeister added the human:needs-work Human reviewer: needs rework label Jul 6, 2026
@thedavidmeister thedavidmeister added ai:needs-work Needs rework — the producer's inbox (vetter verdict or human ruling) and removed human:needs-work Human reviewer: needs rework labels Jul 30, 2026
@thedavidmeister

Copy link
Copy Markdown
Contributor Author

🤖 ai:vetter
vet-protocol 4
lens source@006183de0d37e12b5eb32838955bc8745737986a + audit skill invoked at pr:225
Reviewed 006183d: needs-work — #55: mass-pins =0.8.25 onto six library/abstract src files (ERC4626Extern, ERC4626SubParser, LibERC4626, both LibOpERC4626Convert*, LibERC4626SubParser) — org convention answers inconsistent pragmas PER FILE KIND (^ for library/abstract, = for concrete incl. test mocks), so revert those six to ^0.8.25 and keep only the three test/utils concrete mocks pinned; QA evidence block also missing from the PR body.
cost 135 — mass-pin against per-kind pragma convention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai:needs-work Needs rework — the producer's inbox (vetter verdict or human ruling)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent pragma version style: floating ^0.8.25 vs pinned =0.8.25 across files

1 participant