refactor(fork): use vm.rpcUrl from foundry.toml, remove LibFork hardcoded URL - #222
refactor(fork): use vm.rpcUrl from foundry.toml, remove LibFork hardcoded URL#222thedavidmeister wants to merge 3 commits into
Conversation
…rk hardcoded fallback URL
The fork RPC URL was defined in two places: foundry.toml rpc_endpoints
(with env-var fallback) and as a string constant in test/lib/LibFork.sol.
The fork test then bypassed the foundry.toml entry by calling
vm.envOr("FORK_RPC_URL_BASE", FORK_RPC_URL_BASE) directly.
This removes the duplicate LibFork constant and changes the test to use
vm.rpcUrl("base"), which reads from foundry.toml's rpc_endpoints section
(which already handles the FORK_RPC_URL_BASE env var and the fallback URL).
The RPC URL is now defined exactly once.
Closes #18
Closes #19
Closes #20
Co-Authored-By: Claude <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ack syntax [3b-attempt]
…9-20-fork-rpc-url
|
🤖 ai:vetter |
The fork RPC URL was defined in two places:
foundry.toml[rpc_endpoints](with env-var fallback) and as a string constant intest/lib/LibFork.sol. The fork test then bypassed the foundry.toml entry by callingvm.envOr("FORK_RPC_URL_BASE", FORK_RPC_URL_BASE)directly.This removes the duplicate
FORK_RPC_URL_BASEconstant fromLibFork.soland changessetUp()to usevm.rpcUrl("base"), which reads fromfoundry.toml's[rpc_endpoints]section (which already handles theFORK_RPC_URL_BASEenv var and the fallback URL). The RPC URL is now defined exactly once.Closes #18
Closes #19
Closes #20
Co-Authored-By: Claude noreply@anthropic.com