Skip to content
This repository was archived by the owner on Jul 4, 2026. It is now read-only.

on_providers and refactor #54

Closed
0xgleb wants to merge 5 commits into from
Closed

on_providers and refactor #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
255c24a
ReadProvider
0xgleb Jun 18, 2025
ed643d7
flatten module structure
0xgleb Jun 18, 2025
47b4627
on_provider
0xgleb Jun 18, 2025
566a52e
avoid redundant .to_vec
0xgleb Jun 18, 2025
6476f8f
pub oopsie
0xgleb Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
pub mod transaction;
pub mod read;
pub mod write;
pub mod write_transaction;

pub use read::*;
pub use write::*;
pub use write_transaction::*;
Comment on lines +1 to +7

@coderabbitai coderabbitai Bot Jun 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Avoid wildcard re-exports at the crate root

Re-exporting every public item from the three modules (*) pollutes the top-level namespace and makes it harder to track what is part of the public API. Prefer explicit re-exports or keep the items grouped under their respective modules.

-pub use read::*;
-pub use write::*;
-pub use write_transaction::*;
+pub use read::{ReadableClient, ReadableClientError, ReadContractParameters};
+pub use write::{WritableClient, WritableClientError, WriteContractParameters};
+pub use write_transaction::{WriteTransaction, WriteTransactionStatus};

This keeps the surface area obvious and improves docs.

🤖 Prompt for AI Agents 
In src/lib.rs lines 1 to 7, avoid using wildcard re-exports (pub use read::*;
etc.) at the crate root as it pollutes the top-level namespace. Instead,
explicitly re-export only the necessary public items from each module or keep
the modules grouped without re-exporting everything. This will make the public
API clearer and improve documentation clarity.

@0xgleb 0xgleb Jun 18, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This keeps existing pattern and is fine for the scope of these modules

@coderabbitai coderabbitai Bot Jun 18, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xgleb, understood! I'll note your preference for maintaining the existing pattern with wildcard re-exports in this context.

    (\   /)
   ( ._.)
  o_(")(")  *nods thoughtfully*
✏️ Learnings added 
Learnt from: 0xgleb
PR: rainlanguage/alloy-ethers-typecast#54
File: src/lib.rs:1-7
Timestamp: 2025-06-18T16:26:46.561Z
Learning: In the rainlanguage/alloy-ethers-typecast codebase, wildcard re-exports at the crate root (pub use module::*;) are preferred to maintain existing patterns and are considered appropriate for the scope of the modules.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

Loading