Skip to content

Implemented Contacts API #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Implemented Contacts API #22

merged 3 commits into from
Feb 5, 2025

Conversation

vitalii-t
Copy link
Collaborator

Motivation

Next steps implementing Mailtrap API - Contacts

Changes

  • Added Contacts and Contact Lists API interfaces and implementation
  • Added request and response models
  • Added unit tests
  • Added usage examples

@vitalii-t vitalii-t requested review from mklocek and vittorius and removed request for mklocek January 22, 2025 22:09
Copy link
Contributor

@vittorius vittorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Marcin's comments and added a couple of new ones. Let's fix and proceed.

@vitalii-t vitalii-t requested a review from vittorius January 26, 2025 21:47
@i7an
Copy link

i7an commented Feb 4, 2025

@mklocek is this PR ready to be merged?

@mklocek
Copy link
Contributor

mklocek commented Feb 4, 2025

I think it's ok to merge. The rest of Contacts API that is about to be released can be covered in a different PR

@vitalii-t vitalii-t merged commit 3b775e2 into main Feb 5, 2025
1 check passed
@vitalii-t vitalii-t deleted the feature/contacts-api branch February 5, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants