Deprecate invoke() without arguments.

rails · Jul 25, 2010 · db85b66 · db85b66
1 parent 6a9478b
commit db85b66
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/thor/invocation.rb b/lib/thor/invocation.rb
@@ -94,6 +94,11 @@ def initialize(args=[], options={}, config={}, &block) #:nodoc:
     #   invoke Rspec::RR, [], :style => :foo
     #
     def invoke(name=nil, *args)
+      if name.nil?
+        warn "[Thor] Calling invoke() without argument is deprecated. Please use invoke_all instead.\n#{caller.join("\n")}"
+        return invoke_all
+      end
+
       args.unshift(nil) if Array === args.first || NilClass === args.first
       task, args, opts, config = args
 

diff --git a/spec/invocation_spec.rb b/spec/invocation_spec.rb
@@ -84,7 +84,7 @@
 
     it "raises Thor::UndefinedTaskError if the task can't be found even if all tasks where already executed" do
       base = C.new
-      silence(:stdout){ base.invoke }
+      silence(:stdout){ base.invoke_all }
 
       lambda do
         base.invoke("foo:bar")