Allow customizing input/output via env variables #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Rails `assets:precompile` task internally calls `bin/rails tailwindcss:build`, which uses hardcoded input/output file paths. Previously, the only way to customize these paths was to bypass the Rails integration entirely and use the Tailwind CLI directly (via `bundle exec tailwindcss`). This change introduces TAILWINDCSS_INPUT_FILE and TAILWINDCSS_OUTPUT_FILE environment variables that allow users to override the default paths while still using the standard `assets:precompile` workflow. This is useful for projects with non-standard asset structures or when integrating with custom build pipelines.
thewatts
force-pushed
the
nw/input-output-env-vars
branch
from
be95b05 to
be03a48
Compare
|
Hi @thewatts, thanks for suggesting this change. I'd like to understand the problem you're hoping to solve -- that is, why do you want to change these file names? I'm asking questions because this implementation seems like it's only a partial solution that doesn't address the many places these paths are assumed after installation:
And I'm hoping that by understanding what problem is driving your contribution, that I can make some helpful suggestions. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rails
assets:precompiletask internally callsbin/rails tailwindcss:build, which uses hardcoded input/output file paths. Previously, the only way to customize these paths was to bypass the Rails integration entirely and use the Tailwind CLI directly (viabundle exec tailwindcss).This change introduces TAILWINDCSS_INPUT_FILE and TAILWINDCSS_OUTPUT_FILE environment variables that allow users to override the default paths while still using the standard
assets:precompileworkflow.This is useful for projects with non-standard asset structures or when integrating with custom build pipelines.