Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default key for limits_concurrency #545

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ankane
Copy link

@ankane ankane commented Apr 2, 2025

Hi, this PR adds a default key to limits_concurrency so users don't need to come up with a key name if they only want to limit by job name (regardless of arguments), which I expect is a common case.

class SomeJob < ApplicationJob
  limits_concurrency to: 3
end

Currently, users must use an empty string or another key.

class SomeJob < ApplicationJob
  limits_concurrency key: "", to: 3
end

@ankane
Copy link
Author

ankane commented Apr 3, 2025

The test failure seems to be from a flaky test (also in this CI run from February).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant