New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to pass through the keepalive configuration option #86

Open

brendon wants to merge 1 commit into rails:main from brendon:keepalive

Contributor

brendon commented Mar 8, 2025

I have a few concerns:

We're hard coding the current defaults for fetch for many options. Why not just omit passing them if they're not passed in?
It might be more future proof to allow any options to be passed in, and just override those specific options like contentType and headers as needed.

The solution to those is a much larger change, so for now just allowing keepalive through solves my immediate use-case.

Closes #85


          Add the ability to pass through the keepalive configuration option

37ff677

Contributor Author

brendon commented Mar 8, 2025

CI needs some fixing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet