Skip to content

Conversation

shetty-tejas
Copy link

@shetty-tejas shetty-tejas commented Aug 29, 2024

Inspired from #181.

This PR aims to add a class method to the models that'd give an ability build your own GlobalIDs

Example:

PersonModel.build_global_id(1) => #<GlobalID:0x000000012b7dcea0 @uri=#<URI::GID gid://app/Person/1>>

@nflorentin
Copy link

nflorentin commented Feb 13, 2025

Can't wait to this merged !

Another use case I'm facing: populate a select/options without ajax with a lot of options of mixed models.
Atm, I have to use select instead of pluck which instanciates a lot of active record objects while I could use build_global_id class method to do it.

Copy link
Member

@rafaelfranca rafaelfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the idea but I don't like this implementation. First, it doesn't have the signed counterpart. Second, it is duplication a lot of code with GlobalID.create, so we will probably end up changing one and forgetting to change the other.

@shetty-tejas
Copy link
Author

shetty-tejas commented Sep 18, 2025

Hey @rafaelfranca! Thanks for reviewing the code. I have fixed the code to reuse the existing logic, while also adding the signed counterpart.

You can let me know your thoughts about the current iteration :)

P.S: The tests that are failing seem to be something related to Rails 8, and not due to the code in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants