-
Notifications
You must be signed in to change notification settings - Fork 190
Cookies are signed and encrypte. #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
KartikKumarSahoo
wants to merge
1
commit into
rails:master
from
KartikKumarSahoo:KartikKumarSahoo-patch-1
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,7 +65,7 @@ class ActiveRecordStore < ActionDispatch::Session::AbstractStore | |
end | ||
|
||
private | ||
def get_session(request, sid) | ||
def get_session(request, sid) # NOTE: Doesn't get invoked. | ||
logger.silence_logger do | ||
unless sid and session = @@session_class.find_by_session_id(sid) | ||
# If the sid was nil or if there is no pre-existing session under the sid, | ||
|
@@ -77,9 +77,25 @@ def get_session(request, sid) | |
[sid, session.data] | ||
end | ||
end | ||
|
||
def extract_session_id(request) | ||
stale_session_check! do | ||
unpacked_cookie_data(request) | ||
end | ||
end | ||
|
||
def unpacked_cookie_data(request) | ||
request.fetch_header("action_dispatch.request.unsigned_session_cookie") do |k| | ||
v = stale_session_check! do | ||
get_cookie(request) || {} | ||
end | ||
request.set_header k, v | ||
end | ||
end | ||
|
||
def write_session(request, sid, session_data, options) | ||
logger.silence_logger do | ||
sid ||= get_cookie(request) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need to read the sid from the cookie? Is not it already passed to |
||
record = get_session_model(request, sid) | ||
record.data = session_data | ||
return false unless record.save | ||
|
@@ -136,10 +152,22 @@ def get_session_model(request, id) | |
end | ||
end | ||
|
||
def find_session(request, id) | ||
def find_session(request, id) # NOTE: Doesn't get invoked. | ||
model = get_session_model(request, id) | ||
[model.session_id, model.data] | ||
end | ||
|
||
def set_cookie(request, session_id, cookie) | ||
cookie_jar(request)[@key] = cookie | ||
end | ||
|
||
def get_cookie(request) | ||
cookie_jar(request)[@key] | ||
end | ||
|
||
def cookie_jar(request) | ||
request.cookie_jar.signed_or_encrypted | ||
end | ||
|
||
def logger | ||
ActiveRecord::Base.logger || ActiveRecord::SessionStore::NilLogger | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this comment? I think it is called in versions of Rails before to 5.0