Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements sharing functionality for RMP works, including API support, UI components, and necessary translations, and adds a utility for random save names.
- Introduces
getRandomCityNameto generate random save names. - Extends
API_ENDPOINTandAPISaveInfoto support share operations. - Adds translation entries for sharing UI in multiple locales.
- Implements
ShareModalcomponent for creating/deleting share links.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/random-save-name.ts | New utility with a list of city names for saves |
| src/util/constants.ts | Added /share endpoint and share fields to types |
| src/i18n/translations/zh-Hant.json | Added share-related translation keys |
| src/i18n/translations/zh-Hans.json | Added share-related translation keys |
| src/i18n/translations/ko.json | Added share-related translation keys |
| src/i18n/translations/ja.json | Added share-related translation keys |
| src/components/menu/account-view/share-modal.tsx | New modal component for sharing works |
Comments suppressed due to low confidence (1)
src/components/menu/account-view/share-modal.tsx:151
- The URL appends
.orgto the share token—verify if this suffix is intended or if it should be omitted.
value={`${window.origin}?app=rmp&searchParams=${share.s}.org`}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #221