#218 45 days bonus and sub-subscription#219
Merged
thekingofcity merged 4 commits intomainfrom May 19, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds subscription support by fetching and displaying user subscriptions (including a 45-day bonus reminder), integrates the new API call into login flow, and updates translation keys/UI components to surface subscription-related text.
- Introduce
APISubscriptionandfetchSubscriptionthunk; wire into login and app initialization - Refactor
RedeemModalandSubscriptionSectionto use Redux state for subscriptions - Add translation entries for subscription types and “Renew now and get an extra 45 days!” in all locales
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/constants.ts | Added APISubscription interface |
| src/redux/account/account-slice.ts | New fetchSubscription thunk, updated login flow |
| src/index.tsx | Dispatch fetchSubscription on startup |
| src/components/modal/redeem-modal.tsx | Removed getSubscriptions prop; dispatch new thunk |
| src/components/menu/account-view/subscription-section.tsx | Refactored to read activeSubscriptions from store |
| src/i18n/translations/* | Added translation keys for subscription UI and bonus prompt |
| src/components/menu/account-view/* | Unified title sizes and updated translation keys |
Comments suppressed due to low confidence (1)
src/components/menu/account-view/subscription-section.tsx:86
- [nitpick] A large block of legacy UI code is commented out. Remove or restore it to keep the file clean and avoid confusion.
/* {Object.entries(activeSubscriptions)...*/
wongchito
reviewed
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.