-
Notifications
You must be signed in to change notification settings - Fork 1
Update to use GoMobile #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
update build script
Android build
update scrip build ios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds GoMobile support to the libwallet project, enabling the library to be compiled and used on iOS and Android mobile platforms. The implementation creates a comprehensive wrapper layer that exposes wallet functionality through a mobile-friendly API.
Key changes include:
- Created a new
gomobilepackage with wrapper functions for wallet operations, transactions, syncing, and address management - Added automated build scripts for iOS (XCFramework) and Android (AAR) platforms
- Updated dependencies to include
golang.org/x/mobileand related tools
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tools.go | Adds tool dependencies for gomobile and gobind commands |
| go.mod | Updates Go version and adds golang.org/x/mobile dependency along with transitive dependencies |
| go.sum | Updates dependency checksums for new and updated packages |
| gomobile/gomobile.go | Core initialization and shutdown functions for the mobile library |
| gomobile/types.go | Type definitions, constants, and request/response structures for mobile API |
| gomobile/walletloader.go | Wallet lifecycle management functions (create, load, close, seed retrieval, balance, passphrase change) |
| gomobile/transactions.go | Transaction-related functions (create, send, list, decode, estimate fees) |
| gomobile/sync.go | Synchronization functions and status reporting with SPV notification handlers |
| gomobile/addresses.go | Address management and cryptographic operations (generate, sign, verify) |
| gomobile/utils.go | Helper function for safely accessing loaded wallets |
| gomobile/log.go | Logging infrastructure with support for both file rotation and stdout |
| build_gomobile_ios.sh | Comprehensive iOS build script with device/simulator support and validation |
| build_gomobile_android.sh | Android build script for creating AAR packages with configurable SDK versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR: