Add rock4d other OS tutorial#853
Conversation
There was a problem hiding this comment.
Other comments (4)
-
i18n/en/docusaurus-plugin-content-docs/current/rock4/rock4d/other-os/buildroot.md (23-24)
The symbolic link creation for Python 2 might fail if Python 2 is not installed at `/bin/python2`. Consider using a more robust approach like checking if the file exists first:
sudo apt install python2 git rsync gcc g++ make device-tree-compiler bc flex bison lz4 libssl-dev libgmp-dev libmpc-dev expect expect-dev file unzip bzip2 fakeroot bsdmainutils [ -f /bin/python2 ] && sudo ln -sf /bin/python2 /bin/python || sudo ln -sf $(which python2) /bin/python -
i18n/en/docusaurus-plugin-content-docs/current/rock4/rock4d/other-os/buildroot.md (38-40)
The extraction command assumes the user is already in the directory containing the downloaded tar file. Consider adding a note about this or modifying the command to be more explicit:
# Navigate to the directory where you downloaded the SDK cd /path/to/downloaded/sdk tar xvf rk3576_linux6.1_rkr4_sdk.repo.tar .repo/repo/repo sync -l -
i18n/en/docusaurus-plugin-content-docs/current/rock4/rock4d/other-os/buildroot.md (49-53)
The directory change commands don't specify returning to the top-level directory between each repository modification. This could cause confusion as users might try to run commands from incorrect directories. Consider adding explicit navigation back to the top-level directory:
# First navigate to the top-level SDK directory if you're not already there cd /path/to/sdk/root # Configure device/rockchip repository cd device/rockchip git remote add radxa https://github.com/radxa/device-rockchip.git git fetch radxa git checkout -b rk3576-linux-6.1 remotes/radxa/rk3576-linux-6.1 cd ../../ - docs/rock4/rock4d/other-os/buildroot.md (109-109) There's an inconsistency in the command prompt labels. Previous commands use `Host-Linux$` while this section uses `Host-PC$`. Consider standardizing the prompt labels throughout the document for consistency.
💡 To request another review, post a new comment with "/windsurf-review".
| <NewCodeBlock tip="Host-Windows$" type="host"> | ||
| ``` select disk 3 ``` | ||
| </NewCodeBlock> | ||
|
|
||
| - (如果你的 SD 卡是其他磁盘号,请相应修改 3 为正确的数字。) |
There was a problem hiding this comment.
There's an inconsistency between the command and the comment. The command shows select disk 3 but the comment below says "(如果你的 SD 卡是其他磁盘号,请相应修改 3 为正确的数字。)" which correctly references disk 3. However, in the original text it was disk 1, so the command should either be changed to match the original or the comment should be updated to reflect the new disk number.
| ``` select disk 3 ``` | ||
| </NewCodeBlock> | ||
|
|
||
| - (If your SD card has a different disk number, change 3 to the correct number accordingly.) |
There was a problem hiding this comment.
There's an inconsistency in the disk number reference. The text says "(assuming it is disk 3)" which now matches the command select disk 3, but earlier in the text it says "(If your SD card has a different disk number, change 3 to the correct number accordingly.)" This should be consistent throughout.
| ``` | ||
| sudo apt update | ||
| sudo apt install python2 git rsync gcc g++ make device-tree-compiler bc flex bison lz4 libssl-dev libgmp-dev libmpc-dev expect expect-dev file unzip bzip2 fakeroot bsdmainutils | ||
| sudo ln -s /bin/python2 /bin/python |
There was a problem hiding this comment.
Creating a symlink from /bin/python to Python 2 is not recommended as it may break system tools that expect Python 3. Instead, scripts requiring Python 2 should explicitly use python2. Consider removing this line or adding a warning about potential system impacts.
增加 ROCK 4D 其他操作系统的教程