Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README example #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README example #84

wants to merge 1 commit into from

Conversation

ScullWM
Copy link

@ScullWM ScullWM commented Oct 9, 2019

Hi,

Thanks for this great package!
I've try to reproduce your example but I couldn't make it work at first because of this missing "line".
I hope it will help other peoples.

Thanks

rwese
rwese suggested changes Nov 16, 2019
View reviewed changes
Copy link

@rwese rwese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems outdated as the current version already performs this on line 117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwese rwese rwese requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScullWM @rwese