[cleanup] Remove prefill logprobs recomputation path - #1192
Open
maocheng23 wants to merge 1 commit into
Open
Conversation
Remove the unused --recompute-logprobs-via-prefill flag, rollout hooks, SGLang prefill scoring helper, and tests. The SGLang-level --sglang-enable-prefill-only-deterministic-inference flag remains available for any future model that needs prefill-only deterministic inference.
maocheng23
requested review from
Zhichenzzz,
fzyzcjy,
guapisolo,
jybsuper,
yueming-yuan and
yushengsu-thu
as code owners
May 25, 2026 18:33
6 tasks
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the --recompute-logprobs-via-prefill command-line argument and all associated logic, including the deletion of the utility module miles/rollout/generate_utils/prefill_logprobs.py and its corresponding unit tests. References to this functionality have been cleaned up across argument validation, rollout engines, and configuration tests. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #1088.
Summary
Removes the unused prefill-logprob recomputation path from Miles.
This was split out from the Qwen3 MoE SP+PP true-on-policy support PR so the functional SP+PP support and the controversial cleanup can be reviewed independently.
Main Changes
--recompute-logprobs-via-prefillCLI flag and validation.--sglang-enable-prefill-only-deterministic-inferenceavailable for any future model that genuinely needs prefill-only deterministic inference.Validation
Local split checks:
git diff --checkfor [feat] Add SP and PP support for qwen_moe true on policy #1088 after the splitgit diff --checkfor this stacked removal PRpython -m py_compileover changed Python files in [feat] Add SP and PP support for qwen_moe true on policy #1088 after the splitpython -m py_compileover changed Python files in this stacked removal PRThe prior focused pytest run for the affected true-on-policy/script tests hung locally without producing failures, so I stopped it and did not use it as validation evidence.