fix(mcp): surface non-ErrNoRows GetNode errors in MemoryWrite - #250
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: radimsem <me@radimsemerak.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #218.
Problem
HandleWritediscarded theGetNodeerror withexisting, _ := d.Store.GetNode(ctx, nodeID). Any non-sql.ErrNoRowsfailure (DB locked, ctx cancelled, corrupted page, broken connection) was silently swallowed, and the handler proceeded to construct a brand-new node frompayloaddefaults. When the operator explicitly supplied anAnchor, that turns a transient store failure into a silent defaulted-metadata create instead of a loud, recoverable error.Fix
Surface non-
ErrNoRowserrors while still falling through to the create branch onsql.ErrNoRows, matching the existing pattern inforget.goandsummarize.go:The early return is before the sole
emitNodeChangesite, so the one-snapshot-per-call invariant holds and no snapshot is created on the error path.Test
Adds
TestHandleWrite_SurfacesGetNodeError: a cancelled context forcesGetNodeto returncontext.Canceled(non-ErrNoRows). Verified regression guard — passes with the fix, fails without (the swallowed path surfaces a later, unrelated emit failure:"failed to write: failed to fetch: head snapshot id").Verification
make buildclean ·go vet ./pkg/mcp/...exit 0 ·make testgreen (220 mcp tests) ·make lint0 issues🤖 Generated with Claude Code