feat(mcp): bound MemoryDelta results with a limit - #249
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bounds
MemoryDeltaso a large vault can't blow the LLM context window or overrun the MCP transport in one call — it was the only read tool without a result cap (Search=50,FetchBatch=256,Related=100).Closes #221.
What changed
limitparam onDeltaInput(default 500, ceiling 5000, over-asks clamp rather than error). PlumbedHandleDelta → Engine.Delta → GetDiffsSince → qSelectDiffsSince(LIMIT ?).since_snapshotstays a snapshot id — no client contract change).Engine.Deltapeekslimit+1and trims the trailing partial snapshot, so resuming from the hintedsince_snapshotis lossless.note:continuation hint (returned as text, since results are text-only):Re-call MemoryDelta(since_snapshot=<last complete id>)raise limit (max 5000)MemoryDiff(from_snapshot_id=…, to_snapshot_id=…)escape hatch (that snapshot is provably the immediate-next one, so the diff is scoped to it alone — no inaccessible tail).limitguarded (exportedEngine.Deltareturns empty instead of panicking).skills/remind/references/snapshots-diffs.md,docs/versioning.md.Tests
TestDelta_Limit(fit / trim / boundary / overflow / non-positive guard),TestDeltaTruncationNote(all three note branches),TestHandleDelta_LimitTruncationNote. Full suite,make check-skills, gofmt, andgo vetall green.Review
Project reviewers (
go-style-reviewer,mcp-surface-reviewer) clean; Codex review converged over two rounds (caught the >5000-diff inaccessible-tail regression and a non-positive-limit panic, both fixed).🤖 Generated with Claude Code